Commit Graph

3 Commits

Author SHA1 Message Date
Jason
2aec407a2f test: add dual-parameter support and sync mocks for import/export tests
Update test infrastructure to support the dual app type parameter pattern
(app_type enum + app string) introduced in 590be4e:

- Add toast.warning mock for partial-success status handling
- Add syncCurrentProvidersLive mock to test post-import sync behavior
- Update MSW handlers to accept both app_type and app parameters with
  fallback resolution (app ?? app_type) across 7 provider endpoints
- Add sync_current_providers_live endpoint mock returning success

This ensures test compatibility during the app_type → app parameter
migration and enables testing of the new partial-success import flow.
2025-10-30 10:07:30 +08:00
Jason
521c69db92 test: enhance useImportExport edge tests with mock refactor and callback verification
Mock Refactoring:
- Extract saveFileDialogMock and exportConfigMock as variables
  - Previously used inline vi.fn() which prevented call verification
  - Now supports expect().toHaveBeenCalledWith() assertions
  - Enables parameter and return value validation
- Add mock reset in beforeEach for test isolation
  - Reset saveFileDialogMock state
  - Reset exportConfigMock state
  - Ensures clean state for each test

New Test: Import Failure Callback Verification
- Add test "does not call onImportSuccess when import fails"
  - User selects file successfully
  - Import operation fails (success: false)
  - Verify onImportSuccess callback NOT called
  - Verify status becomes "error"
  - Prevents triggering success logic on failure

New Test: Export Success Message Verification
- Add test "propagates export success message to toast with saved path"
  - User selects save location: /exports/config.json
  - Backend saves to: /final/config.json (may differ)
  - Verify exportConfigMock called with user-selected path
  - Verify toast success message contains actual saved path
  - Ensures user sees correct save location

Coverage Improvements:
- Import failure callback: 50% → 100%
- Export success message: 50% → 100%
- Mock verification capability: 0% → 100%

All tests passing: 81/81 (2 new tests)
2025-10-26 09:55:19 +08:00
Jason
d65621a556 test: add error handling and edge case tests for hooks
useSettings Tests:
- Add test for null settings state protection
  - Returns null immediately without calling APIs
  - Prevents null pointer errors in save flow
- Add test for save mutation failure
  - Verifies error propagates to caller
  - Ensures restart flag remains untouched on failure
  - Validates no side effects when save fails

useProviderActions Tests:
- Add error propagation tests for CRUD operations
  - updateProvider: propagates errors to caller
  - addProvider: propagates errors to caller
  - deleteProvider: propagates errors to caller
- Add switch mutation error handling tests
  - Claude switch: handles errors silently (no throw)
  - Codex switch: skips plugin sync when mutation fails
  - Verifies plugin sync APIs not called on failure
- Add loading state verification
  - Test all mutations pending scenario (existing)
  - Test all mutations idle scenario (new)
  - Ensures isLoading flag accuracy

useImportExport Edge Case Tests (new file):
- Add test for user cancelling file dialog
  - File dialog returns null (user cancelled)
  - State remains unchanged (selectedFile: "", status: "idle")
  - No error toast shown
- Add test for resetStatus behavior
  - Clears error message and status
  - Preserves selected file path for retry
  - Resets backupId to null

All tests passing: 79/79 (10 new tests)
2025-10-25 22:51:51 +08:00