Jason
80dd6e9381
refactor(api): unify AppType parsing with FromStr trait
...
BREAKING CHANGE: Remove support for legacy app_type/appType parameters.
All Tauri commands now accept only the 'app' parameter (values: "claude" or "codex").
Invalid app values will return localized error messages with allowed values.
This commit addresses code duplication and improves error handling:
- Consolidate AppType parsing into FromStr trait implementation
* Eliminates duplicate parse_app() functions across 3 command modules
* Provides single source of truth for app type validation
* Enables idiomatic Rust .parse::<AppType>() syntax
- Enhance error messages with localization
* Return bilingual error messages (Chinese + English)
* Include list of allowed values in error responses
* Use structured AppError::localized for better categorization
- Add input normalization
* Case-insensitive matching ("CLAUDE" → AppType::Claude)
* Automatic whitespace trimming (" codex \n" → AppType::Codex)
* Improves API robustness against user input variations
- Introduce comprehensive unit tests
* Test valid inputs with case variations
* Test whitespace handling
* Verify error message content and localization
* 100% coverage of from_str logic
- Update documentation
* Add CHANGELOG entry marking breaking change
* Update README with accurate architecture description
* Revise REFACTORING_MASTER_PLAN with migration examples
* Remove all legacy app_type/appType references
Code Quality Metrics:
- Lines removed: 27 (duplicate code)
- Lines added: 52 (including tests and docs)
- Code duplication: 3 → 0 instances
- Test coverage: 0% → 100% for AppType parsing
2025-10-30 12:33:35 +08:00
Jason
f3e7412a14
feat: complete stage 4 cleanup and code formatting
...
This commit completes stage 4 of the refactoring plan, focusing on cleanup
and optimization of the modernized codebase.
## Key Changes
### Code Cleanup
- Remove legacy `src/lib/styles.ts` (no longer needed)
- Remove old modal components (`ImportProgressModal.tsx`, `ProviderList.tsx`)
- Streamline `src/lib/tauri-api.ts` from 712 lines to 17 lines (-97.6%)
- Remove global `window.api` pollution
- Keep only event listeners (`tauriEvents.onProviderSwitched`)
- All API calls now use modular `@/lib/api/*` layer
### Type System
- Clean up `src/vite-env.d.ts` (remove 156 lines of outdated types)
- Remove obsolete global type declarations
- All TypeScript checks pass with zero errors
### Code Formatting
- Format all source files with Prettier (82 files)
- Fix formatting issues in 15 files:
- App.tsx and core components
- MCP management components
- Settings module components
- Provider management components
- UI components
### Documentation Updates
- Update `REFACTORING_CHECKLIST.md` with stage 4 progress
- Mark completed tasks in `REFACTORING_MASTER_PLAN.md`
## Impact
**Code Reduction:**
- Total: -1,753 lines, +384 lines (net -1,369 lines)
- tauri-api.ts: 712 → 17 lines (-97.6%)
- Removed styles.ts: -82 lines
- Removed vite-env.d.ts declarations: -156 lines
**Quality Improvements:**
- ✅ Zero TypeScript errors
- ✅ Zero TODO/FIXME comments
- ✅ 100% Prettier compliant
- ✅ Zero `window.api` references
- ✅ Fully modular API layer
## Testing
- [x] TypeScript compilation passes
- [x] Code formatting validated
- [x] No linting errors
Stage 4 completion: 100%
Ready for stage 5 (testing and bug fixes)
2025-10-16 12:13:51 +08:00
Jason
2b45af118f
feat: complete stage 3 settings refactor
2025-10-16 11:40:02 +08:00
Jason
b88eb88608
feat: complete stage 2 core refactor
2025-10-16 10:49:56 +08:00
Jason
cc0b7053aa
feat: complete stage 1 infrastructure
2025-10-16 10:00:22 +08:00
Jason
95e2d84655
docs: add comprehensive refactoring documentation
...
Add three key documents to guide the project restructure:
- REFACTORING_MASTER_PLAN.md: Complete refactoring roadmap with 6 stages
- REFACTORING_CHECKLIST.md: Detailed task checklist for tracking progress
- REFACTORING_REFERENCE.md: Technical reference and implementation guide
This refactoring aims to modernize the codebase with React Query,
react-hook-form, zod validation, and shadcn/ui components while
maintaining the current Tailwind CSS 4.x stack.
🤖 Generated with [Claude Code](https://claude.com/claude-code )
Co-Authored-By: Claude <noreply@anthropic.com >
2025-10-16 09:38:41 +08:00
