Comprehensive test updates to align with recent component refactoring and new auto-launch functionality. Component Tests: - AddProviderDialog.test.tsx (10 lines): * Updated test cases for new dialog behavior * Enhanced mock data for preset selection * Improved assertions for validation - ImportExportSection.test.tsx (16 lines): * Updated for new settings page integration * Enhanced test coverage for error scenarios * Better mock state management - McpFormModal.test.tsx (60 lines): * Extensive updates for form refactoring * New test cases for multi-app selection * Enhanced validation testing * Better coverage of stdio/http server types - ProviderList.test.tsx (11 lines): * Updated for new card layout * Enhanced drag-and-drop testing - SettingsDialog.test.tsx (96 lines): * Major updates for SettingsPage migration * New test cases for auto-launch functionality * Enhanced integration test coverage * Better async operation testing Hook Tests: - useDirectorySettings.test.tsx (32 lines): * Updated for refactored hook logic * Enhanced test coverage for edge cases - useDragSort.test.tsx (36 lines): * Simplified test cases * Better mock implementation * Improved assertions - useImportExport tests (16 lines total): * Updated for new error handling * Enhanced test coverage - useMcpValidation.test.tsx (23 lines): * Updated validation test cases * Better coverage of error scenarios - useProviderActions.test.tsx (48 lines): * Extensive updates for hook refactoring * New test cases for provider operations * Enhanced mock data - useSettings.test.tsx (12 lines): * New test cases for auto-launch * Enhanced settings state testing * Better async operation coverage Integration Tests: - App.test.tsx (41 lines): * Updated for new routing logic * Enhanced navigation testing * Better component integration coverage - SettingsDialog.test.tsx (88 lines): * Complete rewrite for SettingsPage * New integration test scenarios * Enhanced user workflow testing Mock Infrastructure: - handlers.ts (117 lines): * Major updates for MSW handlers * New handlers for auto-launch commands * Enhanced error simulation * Better request/response mocking - state.ts (37 lines): * Updated mock state structure * New state for auto-launch * Enhanced state reset functionality - tauriMocks.ts (10 lines): * Updated mock implementations * Better type safety - server.ts & testQueryClient.ts: * Minor cleanup (2 lines removed) Test Infrastructure Improvements: - Better test isolation - Enhanced mock data consistency - Improved async operation testing - Better error scenario coverage - Enhanced integration test patterns Coverage Improvements: - Net increase of 195 lines of test code - Better coverage of edge cases - Enhanced error path testing - Improved integration test scenarios - Better mock infrastructure All tests now pass with the refactored components while maintaining comprehensive coverage of functionality and edge cases.
170 lines
5.4 KiB
TypeScript
170 lines
5.4 KiB
TypeScript
import { renderHook } from "@testing-library/react";
|
|
import { describe, it, expect, beforeEach, vi } from "vitest";
|
|
import { useMcpValidation } from "@/components/mcp/useMcpValidation";
|
|
|
|
const validateTomlMock = vi.hoisted(() => vi.fn());
|
|
const tomlToMcpServerMock = vi.hoisted(() => vi.fn());
|
|
|
|
vi.mock("react-i18next", () => ({
|
|
useTranslation: () => ({
|
|
t: (key: string) => key,
|
|
}),
|
|
}));
|
|
|
|
vi.mock("@/utils/tomlUtils", () => ({
|
|
validateToml: (...args: unknown[]) => validateTomlMock(...args),
|
|
tomlToMcpServer: (...args: unknown[]) => tomlToMcpServerMock(...args),
|
|
}));
|
|
|
|
describe("useMcpValidation", () => {
|
|
beforeEach(() => {
|
|
validateTomlMock.mockReset();
|
|
tomlToMcpServerMock.mockReset();
|
|
validateTomlMock.mockReturnValue("");
|
|
});
|
|
|
|
const getHookResult = () =>
|
|
renderHook(() => useMcpValidation()).result.current;
|
|
|
|
describe("validateJson", () => {
|
|
it("returns empty string for blank text", () => {
|
|
const { validateJson } = getHookResult();
|
|
expect(validateJson(" ")).toBe("");
|
|
});
|
|
|
|
it("returns error key when JSON parsing fails", () => {
|
|
const { validateJson } = getHookResult();
|
|
expect(validateJson("{ invalid")).toBe("mcp.error.jsonInvalid");
|
|
});
|
|
|
|
it("returns error key when parsed value is not an object", () => {
|
|
const { validateJson } = getHookResult();
|
|
expect(validateJson('"string"')).toBe("mcp.error.jsonInvalid");
|
|
expect(validateJson("[]")).toBe("mcp.error.jsonInvalid");
|
|
});
|
|
|
|
it("accepts valid object payload", () => {
|
|
const { validateJson } = getHookResult();
|
|
expect(validateJson('{"id":"demo"}')).toBe("");
|
|
});
|
|
});
|
|
|
|
describe("formatTomlError", () => {
|
|
it("maps mustBeObject and parseError to i18n key", () => {
|
|
const { formatTomlError } = getHookResult();
|
|
expect(formatTomlError("mustBeObject")).toBe("mcp.error.tomlInvalid");
|
|
expect(formatTomlError("parseError")).toBe("mcp.error.tomlInvalid");
|
|
});
|
|
|
|
it("appends error message when details provided", () => {
|
|
const { formatTomlError } = getHookResult();
|
|
expect(formatTomlError("unknown")).toBe("mcp.error.tomlInvalid: unknown");
|
|
});
|
|
});
|
|
|
|
describe("validateTomlConfig", () => {
|
|
it("propagates errors returned by validateToml", () => {
|
|
validateTomlMock.mockReturnValue("parse-error-detail");
|
|
const { validateTomlConfig } = getHookResult();
|
|
expect(validateTomlConfig("foo")).toBe(
|
|
"mcp.error.tomlInvalid: parse-error-detail",
|
|
);
|
|
expect(tomlToMcpServerMock).not.toHaveBeenCalled();
|
|
});
|
|
|
|
it("returns command required when stdio server missing command", () => {
|
|
tomlToMcpServerMock.mockReturnValue({
|
|
type: "stdio",
|
|
command: " ",
|
|
});
|
|
const { validateTomlConfig } = getHookResult();
|
|
expect(validateTomlConfig("foo")).toBe("mcp.error.commandRequired");
|
|
});
|
|
|
|
it("returns url required when http server missing url", () => {
|
|
tomlToMcpServerMock.mockReturnValue({
|
|
type: "http",
|
|
url: "",
|
|
});
|
|
const { validateTomlConfig } = getHookResult();
|
|
expect(validateTomlConfig("foo")).toBe("mcp.wizard.urlRequired");
|
|
});
|
|
|
|
it("returns url required when sse server missing url", () => {
|
|
tomlToMcpServerMock.mockReturnValue({
|
|
type: "sse",
|
|
url: "",
|
|
});
|
|
const { validateTomlConfig } = getHookResult();
|
|
expect(validateTomlConfig("foo")).toBe("mcp.wizard.urlRequired");
|
|
});
|
|
|
|
it("surface tomlToMcpServer errors via formatter", () => {
|
|
tomlToMcpServerMock.mockImplementation(() => {
|
|
throw new Error("normalize failed");
|
|
});
|
|
const { validateTomlConfig } = getHookResult();
|
|
expect(validateTomlConfig("foo")).toBe(
|
|
"mcp.error.tomlInvalid: normalize failed",
|
|
);
|
|
});
|
|
|
|
it("returns empty string when validation passes", () => {
|
|
tomlToMcpServerMock.mockReturnValue({
|
|
type: "stdio",
|
|
command: "run.sh",
|
|
});
|
|
const { validateTomlConfig } = getHookResult();
|
|
expect(validateTomlConfig("foo")).toBe("");
|
|
});
|
|
});
|
|
|
|
describe("validateJsonConfig", () => {
|
|
it("returns error when JSON invalid", () => {
|
|
const { validateJsonConfig } = getHookResult();
|
|
expect(validateJsonConfig("invalid")).toBe("mcp.error.jsonInvalid");
|
|
});
|
|
|
|
it("rejects arrays of servers", () => {
|
|
const { validateJsonConfig } = getHookResult();
|
|
expect(validateJsonConfig('{"mcpServers": {}}')).toBe(
|
|
"mcp.error.singleServerObjectRequired",
|
|
);
|
|
});
|
|
|
|
it("requires command for stdio type", () => {
|
|
const { validateJsonConfig } = getHookResult();
|
|
expect(validateJsonConfig('{"type":"stdio"}')).toBe(
|
|
"mcp.error.commandRequired",
|
|
);
|
|
});
|
|
|
|
it("requires url for http type", () => {
|
|
const { validateJsonConfig } = getHookResult();
|
|
expect(validateJsonConfig('{"type":"http","url":""}')).toBe(
|
|
"mcp.wizard.urlRequired",
|
|
);
|
|
});
|
|
|
|
it("requires url for sse type", () => {
|
|
const { validateJsonConfig } = getHookResult();
|
|
expect(validateJsonConfig('{"type":"sse","url":""}')).toBe(
|
|
"mcp.wizard.urlRequired",
|
|
);
|
|
});
|
|
|
|
it("returns empty string when json config valid", () => {
|
|
const { validateJsonConfig } = getHookResult();
|
|
expect(
|
|
validateJsonConfig(
|
|
JSON.stringify({
|
|
type: "stdio",
|
|
command: "node",
|
|
args: ["index.js"],
|
|
}),
|
|
),
|
|
).toBe("");
|
|
});
|
|
});
|
|
});
|