From 1c43a1d55bf38c85651e8a6b74e12026116f1545 Mon Sep 17 00:00:00 2001 From: Quentin McGaw Date: Sat, 7 Oct 2023 13:21:32 +0000 Subject: [PATCH] fix(portforward): service start error not treated as critical A service start error can happen if the service is started after the Wireguard VPN tunnel is up, but the tunnel does not work. The VPN is then internally restarted, causing the service start error, so it should not be treated as a critical error. --- internal/portforward/loop.go | 6 ------ 1 file changed, 6 deletions(-) diff --git a/internal/portforward/loop.go b/internal/portforward/loop.go index 23a9566c..53a6afce 100644 --- a/internal/portforward/loop.go +++ b/internal/portforward/loop.go @@ -121,12 +121,6 @@ func (l *Loop) run(runCtx context.Context, runDone chan<- struct{}, // and if it failed to start. updateResult <- err } - if err != nil { - if runCtx.Err() == nil { // crashed but NOT stopped - runErrorCh <- fmt.Errorf("starting new service: %w", err) - } - return - } } }