From 3025476e8b3c7f5a25f2b9b9d750ebeea0e548dc Mon Sep 17 00:00:00 2001 From: Quentin McGaw Date: Thu, 13 Nov 2025 14:10:13 +0000 Subject: [PATCH] chore(portforward): remove double log when clearing port forward file --- internal/portforward/service/fs.go | 6 +++++- internal/portforward/service/stop.go | 2 -- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/internal/portforward/service/fs.go b/internal/portforward/service/fs.go index cc389fed..6c6e4537 100644 --- a/internal/portforward/service/fs.go +++ b/internal/portforward/service/fs.go @@ -14,7 +14,11 @@ func (s *Service) writePortForwardedFile(ports []uint16) (err error) { fileData := []byte(strings.Join(portStrings, "\n")) filepath := s.settings.Filepath - s.logger.Info("writing port file " + filepath) + if len(ports) == 0 { + s.logger.Info("clearing port file " + filepath) + } else { + s.logger.Info("writing port file " + filepath) + } const perms = os.FileMode(0o644) err = os.WriteFile(filepath, fileData, perms) if err != nil { diff --git a/internal/portforward/service/stop.go b/internal/portforward/service/stop.go index 04eda5f8..085dbcdc 100644 --- a/internal/portforward/service/stop.go +++ b/internal/portforward/service/stop.go @@ -59,8 +59,6 @@ func (s *Service) cleanup() (err error) { s.ports = nil - filepath := s.settings.Filepath - s.logger.Info("clearing port file " + filepath) err = s.writePortForwardedFile(nil) if err != nil { return fmt.Errorf("clearing port file: %w", err)