chore(lint): upgrade linter from v1.56.2 to v1.61.0
- Remove no longer needed exclude rules - Add new exclude rules for printf govet errors - Remove deprecated linters `execinquery` and `exportloopref` - Rename linter `goerr113` to `err113` - Rename linter `gomnd` to `mnd`
This commit is contained in:
@@ -35,7 +35,7 @@ func checkResponse(response []byte, expectedOperationCode byte,
|
||||
ErrResponseSizeTooSmall, minResponseSize, len(response))
|
||||
}
|
||||
|
||||
if len(response) != int(expectedResponseSize) {
|
||||
if uint(len(response)) != expectedResponseSize {
|
||||
return fmt.Errorf("%w: expected %d bytes and got %d byte(s)",
|
||||
ErrResponseSizeUnexpected, expectedResponseSize, len(response))
|
||||
}
|
||||
@@ -73,7 +73,7 @@ var (
|
||||
// if the result code is not a success (0).
|
||||
// See https://www.ietf.org/rfc/rfc6886.html#section-3.5
|
||||
//
|
||||
//nolint:gomnd
|
||||
//nolint:mnd
|
||||
func checkResultCode(resultCode uint16) (err error) {
|
||||
switch resultCode {
|
||||
case 0:
|
||||
|
||||
@@ -53,7 +53,7 @@ func Test_Client_ExternalAddress(t *testing.T) {
|
||||
remoteAddress := launchUDPServer(t, testCase.exchanges)
|
||||
|
||||
client := Client{
|
||||
serverPort: uint16(remoteAddress.Port),
|
||||
serverPort: uint16(remoteAddress.Port), //nolint:gosec
|
||||
initialConnectionDuration: testCase.initialConnDuration,
|
||||
maxRetries: 1,
|
||||
}
|
||||
|
||||
@@ -122,7 +122,7 @@ func Test_Client_AddPortMapping(t *testing.T) {
|
||||
remoteAddress := launchUDPServer(t, testCase.exchanges)
|
||||
|
||||
client := Client{
|
||||
serverPort: uint16(remoteAddress.Port),
|
||||
serverPort: uint16(remoteAddress.Port), //nolint:gosec
|
||||
initialConnectionDuration: testCase.initialConnectionDuration,
|
||||
maxRetries: 1,
|
||||
}
|
||||
|
||||
@@ -145,7 +145,7 @@ func Test_Client_rpc(t *testing.T) {
|
||||
remoteAddress := launchUDPServer(t, testCase.exchanges)
|
||||
|
||||
client := Client{
|
||||
serverPort: uint16(remoteAddress.Port),
|
||||
serverPort: uint16(remoteAddress.Port), //nolint:gosec
|
||||
initialConnectionDuration: testCase.initialConnectionDuration,
|
||||
maxRetries: 1,
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user