diff --git a/internal/server/dns.go b/internal/server/dns.go index a77310f7..da453714 100644 --- a/internal/server/dns.go +++ b/internal/server/dns.go @@ -32,10 +32,10 @@ func (h *dnsHandler) ServeHTTP(w http.ResponseWriter, r *http.Request) { case http.MethodPut: h.setStatus(w, r) default: - http.Error(w, "", http.StatusNotFound) + http.Error(w, "method "+r.Method+" not supported", http.StatusBadRequest) } default: - http.Error(w, "", http.StatusNotFound) + http.Error(w, "route "+r.RequestURI+" not supported", http.StatusBadRequest) } } diff --git a/internal/server/handlerv0.go b/internal/server/handlerv0.go index 9313b68e..6f2c92ea 100644 --- a/internal/server/handlerv0.go +++ b/internal/server/handlerv0.go @@ -28,7 +28,7 @@ type handlerV0 struct { func (h *handlerV0) ServeHTTP(w http.ResponseWriter, r *http.Request) { if r.Method != http.MethodGet { - http.Error(w, "unversioned API: only supports GET method", http.StatusNotFound) + http.Error(w, "unversioned API: only supports GET method", http.StatusBadRequest) return } switch r.RequestURI { @@ -63,6 +63,6 @@ func (h *handlerV0) ServeHTTP(w http.ResponseWriter, r *http.Request) { h.logger.Warn(err.Error()) } default: - http.Error(w, "unversioned API: requested URI not found", http.StatusNotFound) + http.Error(w, "unversioned API: requested URI not found", http.StatusBadRequest) } } diff --git a/internal/server/handlerv1.go b/internal/server/handlerv1.go index a8fbd1b8..f2296eb3 100644 --- a/internal/server/handlerv1.go +++ b/internal/server/handlerv1.go @@ -44,7 +44,7 @@ func (h *handlerV1) ServeHTTP(w http.ResponseWriter, r *http.Request) { h.publicip.ServeHTTP(w, r) default: errString := fmt.Sprintf("%s %s not found", r.Method, r.RequestURI) - http.Error(w, errString, http.StatusNotFound) + http.Error(w, errString, http.StatusBadRequest) } } diff --git a/internal/server/openvpn.go b/internal/server/openvpn.go index 0b58ce33..8bc45b6a 100644 --- a/internal/server/openvpn.go +++ b/internal/server/openvpn.go @@ -34,24 +34,24 @@ func (h *openvpnHandler) ServeHTTP(w http.ResponseWriter, r *http.Request) { case http.MethodPut: h.setStatus(w, r) default: - http.Error(w, "", http.StatusNotFound) + http.Error(w, "method "+r.Method+" not supported", http.StatusBadRequest) } case "/settings": switch r.Method { case http.MethodGet: h.getSettings(w) default: - http.Error(w, "", http.StatusNotFound) + http.Error(w, "method "+r.Method+" not supported", http.StatusBadRequest) } case "/portforwarded": switch r.Method { case http.MethodGet: h.getPortForwarded(w) default: - http.Error(w, "", http.StatusNotFound) + http.Error(w, "method "+r.Method+" not supported", http.StatusBadRequest) } default: - http.Error(w, "", http.StatusNotFound) + http.Error(w, "route "+r.RequestURI+" not supported", http.StatusBadRequest) } } diff --git a/internal/server/publicip.go b/internal/server/publicip.go index 7a5dba92..8e60f609 100644 --- a/internal/server/publicip.go +++ b/internal/server/publicip.go @@ -26,10 +26,10 @@ func (h *publicIPHandler) ServeHTTP(w http.ResponseWriter, r *http.Request) { case http.MethodGet: h.getPublicIP(w) default: - http.Error(w, "", http.StatusNotFound) + http.Error(w, "method "+r.Method+" not supported", http.StatusBadRequest) } default: - http.Error(w, "", http.StatusNotFound) + http.Error(w, "route "+r.RequestURI+" not supported", http.StatusBadRequest) } } diff --git a/internal/server/updater.go b/internal/server/updater.go index d1037e53..b0cb0a6f 100644 --- a/internal/server/updater.go +++ b/internal/server/updater.go @@ -44,10 +44,10 @@ func (h *updaterHandler) ServeHTTP(w http.ResponseWriter, r *http.Request) { case http.MethodPut: h.setStatus(w, r) default: - http.Error(w, "", http.StatusNotFound) + http.Error(w, "method "+r.Method+" not supported", http.StatusBadRequest) } default: - http.Error(w, "", http.StatusNotFound) + http.Error(w, "route "+r.RequestURI+" not supported", http.StatusBadRequest) } }