admin/gluetun
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix restart mutex unlocking for loops

Browse Source
This commit is contained in:
Quentin McGaw (desktop)
2021-08-09 14:38:15 +00:00
parent c777f8d97d
commit 61066e3896
1 changed files with 3 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
internal/loopstate/apply.go
View File

@@ -37,6 +37,7 @@ func (s *State) ApplyStatus(ctx context.Context, status models.LoopStatus) (
switch existingStatus { switch existingStatus {
case constants.Stopped, constants.Completed: case constants.Stopped, constants.Completed:
default: default:
s.statusMu.Unlock()
return "already " + existingStatus.String(), nil return "already " + existingStatus.String(), nil
} }
@@ -55,6 +56,7 @@ func (s *State) ApplyStatus(ctx context.Context, status models.LoopStatus) (
return newStatus.String(), nil return newStatus.String(), nil
case constants.Stopped: case constants.Stopped:
if existingStatus != constants.Running { if existingStatus != constants.Running {
s.statusMu.Unlock()
return "already " + existingStatus.String(), nil return "already " + existingStatus.String(), nil
} }
@@ -73,6 +75,7 @@ func (s *State) ApplyStatus(ctx context.Context, status models.LoopStatus) (
return newStatus.String(), nil return newStatus.String(), nil
default: default:
s.statusMu.Unlock()
return "", fmt.Errorf("%w: %s: it can only be one of: %s, %s", return "", fmt.Errorf("%w: %s: it can only be one of: %s, %s",
ErrInvalidStatus, status, constants.Running, constants.Stopped) ErrInvalidStatus, status, constants.Running, constants.Stopped)
} }