From 698095f0a0260e97811c2b8ae9494caf463754c6 Mon Sep 17 00:00:00 2001 From: Quentin McGaw Date: Tue, 15 Nov 2022 12:45:47 +0000 Subject: [PATCH] fix(pprof): do not run if disabled --- cmd/gluetun/main.go | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/cmd/gluetun/main.go b/cmd/gluetun/main.go index 3fde74c0..55f532b4 100644 --- a/cmd/gluetun/main.go +++ b/cmd/gluetun/main.go @@ -354,11 +354,14 @@ func _main(ctx context.Context, buildInfo models.BuildInformation, tickersGroupHandler := goshutdown.NewGroupHandler("tickers", defaultGroupOptions...) otherGroupHandler := goshutdown.NewGroupHandler("other", defaultGroupOptions...) - pprofReady := make(chan struct{}) - pprofHandler, pprofCtx, pprofDone := goshutdown.NewGoRoutineHandler("pprof server") - go pprofServer.Run(pprofCtx, pprofReady, pprofDone) - otherGroupHandler.Add(pprofHandler) - <-pprofReady + if *allSettings.Pprof.Enabled { + // TODO run in run loop so this can be patched at runtime + pprofReady := make(chan struct{}) + pprofHandler, pprofCtx, pprofDone := goshutdown.NewGoRoutineHandler("pprof server") + go pprofServer.Run(pprofCtx, pprofReady, pprofDone) + otherGroupHandler.Add(pprofHandler) + <-pprofReady + } portForwardLogger := logger.New(log.SetComponent("port forwarding")) portForwardLooper := portforward.NewLoop(allSettings.VPN.Provider.PortForwarding,