admin/gluetun
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Using context for HTTP requests

Browse Source
This commit is contained in:
Quentin McGaw
2020-10-17 21:54:09 +00:00
parent 0d2ca377df
commit 6f4be72785
7 changed files with 37 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
internal/version/github.go
View File

@@ -1,10 +1,13 @@
package version
import (
"context"
"encoding/json"
"io/ioutil"
"net/http"
"time"
"golang.org/x/net/context/ctxhttp"
)
type githubRelease struct {
@@ -23,9 +26,9 @@ type githubCommit struct {
}
}
func getGithubReleases(client *http.Client) (releases []githubRelease, err error) {
func getGithubReleases(ctx context.Context, client *http.Client) (releases []githubRelease, err error) {
const url = "https://api.github.com/repos/qdm12/gluetun/releases"
response, err := client.Get(url)
response, err := ctxhttp.Get(ctx, client, url)
if err != nil {
return nil, err
}
@@ -40,9 +43,9 @@ func getGithubReleases(client *http.Client) (releases []githubRelease, err error
return releases, nil
}
func getGithubCommits(client *http.Client) (commits []githubCommit, err error) {
func getGithubCommits(ctx context.Context, client *http.Client) (commits []githubCommit, err error) {
const url = "https://api.github.com/repos/qdm12/gluetun/commits"
response, err := client.Get(url)
response, err := ctxhttp.Get(ctx, client, url)
if err != nil {
return nil, err
}