chore(lint): add new linters and update codebase

- add canonicalheader
- add copyloopvar
- add fatcontext
- add intrange

internal/provider/custom/openvpnconf_test.go

@@ -79,7 +79,6 @@ func Test_modifyConfig(t *testing.T) {
 	}
 
 	for name, testCase := range testCases {
-		testCase := testCase
 		t.Run(name, func(t *testing.T) {
 			t.Parallel()
 

internal/provider/expressvpn/connection_test.go

@@ -77,7 +77,6 @@ func Test_Provider_GetConnection(t *testing.T) {
 	}
 
 	for name, testCase := range testCases {
-		testCase := testCase
 		t.Run(name, func(t *testing.T) {
 			t.Parallel()
 			ctrl := gomock.NewController(t)

internal/provider/fastestvpn/updater/api.go

@@ -77,7 +77,7 @@ func fetchAPIServers(ctx context.Context, client *http.Client, protocol string)
 		var server apiServer
 
 		const numberOfTDBlocks = 3
-		for i := 0; i < numberOfTDBlocks; i++ {
+		for i := range numberOfTDBlocks {
 			tdBlock := getNextTDBlock(trBlock)
 			if tdBlock == nil {
 				return nil, fmt.Errorf("%w: expected 3 <td> blocks in <tr> block %q",

internal/provider/fastestvpn/updater/api_test.go

@@ -89,7 +89,6 @@ func Test_fechAPIServers(t *testing.T) {
 	}
 
 	for name, testCase := range testCases {
-		testCase := testCase
 		t.Run(name, func(t *testing.T) {
 			t.Parallel()
 
@@ -152,7 +151,6 @@ func Test_getNextBlock(t *testing.T) {
 	}
 
 	for name, testCase := range testCases {
-		testCase := testCase
 		t.Run(name, func(t *testing.T) {
 			t.Parallel()
 

internal/provider/ipvanish/updater/filename_test.go

@@ -37,7 +37,6 @@ func Test_parseFilename(t *testing.T) {
 		},
 	}
 	for name, testCase := range testCases {
-		testCase := testCase
 		t.Run(name, func(t *testing.T) {
 			t.Parallel()
 

internal/provider/ipvanish/updater/hosttoserver_test.go

@@ -87,7 +87,6 @@ func Test_hostToServer_add(t *testing.T) {
 		},
 	}
 	for name, testCase := range testCases {
-		testCase := testCase
 		t.Run(name, func(t *testing.T) {
 			t.Parallel()
 			testCase.initialHTS.add(testCase.host, testCase.country, testCase.city, testCase.tcp, testCase.udp)
@@ -121,7 +120,6 @@ func Test_hostToServer_toHostsSlice(t *testing.T) {
 		},
 	}
 	for name, testCase := range testCases {
-		testCase := testCase
 		t.Run(name, func(t *testing.T) {
 			t.Parallel()
 			hosts := testCase.hts.toHostsSlice()
@@ -175,7 +173,6 @@ func Test_hostToServer_adaptWithIPs(t *testing.T) {
 		},
 	}
 	for name, testCase := range testCases {
-		testCase := testCase
 		t.Run(name, func(t *testing.T) {
 			t.Parallel()
 			testCase.initialHTS.adaptWithIPs(testCase.hostToIPs)
@@ -206,7 +203,6 @@ func Test_hostToServer_toServersSlice(t *testing.T) {
 		},
 	}
 	for name, testCase := range testCases {
-		testCase := testCase
 		t.Run(name, func(t *testing.T) {
 			t.Parallel()
 			servers := testCase.hts.toServersSlice()

internal/provider/ipvanish/updater/servers_test.go

@@ -187,7 +187,6 @@ func Test_Updater_GetServers(t *testing.T) {
 		},
 	}
 	for name, testCase := range testCases {
-		testCase := testCase
 		t.Run(name, func(t *testing.T) {
 			t.Parallel()
 			ctrl := gomock.NewController(t)

internal/provider/ivpn/connection_test.go

@@ -88,7 +88,6 @@ func Test_Provider_GetConnection(t *testing.T) {
 	}
 
 	for name, testCase := range testCases {
-		testCase := testCase
 		t.Run(name, func(t *testing.T) {
 			t.Parallel()
 			ctrl := gomock.NewController(t)

internal/provider/ivpn/updater/api_test.go

@@ -63,7 +63,6 @@ func Test_fetchAPI(t *testing.T) {
 		},
 	}
 	for name, testCase := range testCases {
-		testCase := testCase
 		t.Run(name, func(t *testing.T) {
 			t.Parallel()
 

internal/provider/ivpn/updater/servers_test.go

@@ -131,7 +131,6 @@ func Test_Updater_GetServers(t *testing.T) {
 		},
 	}
 	for name, testCase := range testCases {
-		testCase := testCase
 		t.Run(name, func(t *testing.T) {
 			t.Parallel()
 			ctrl := gomock.NewController(t)

internal/provider/mullvad/connection_test.go

@@ -88,7 +88,6 @@ func Test_Provider_GetConnection(t *testing.T) {
 	}
 
 	for name, testCase := range testCases {
-		testCase := testCase
 		t.Run(name, func(t *testing.T) {
 			t.Parallel()
 			ctrl := gomock.NewController(t)

internal/provider/mullvad/updater/ips_test.go

@@ -31,7 +31,6 @@ func Test_uniqueSortedIPs(t *testing.T) {
 		},
 	}
 	for name, testCase := range testCases {
-		testCase := testCase
 		t.Run(name, func(t *testing.T) {
 			t.Parallel()
 			outputIPs := uniqueSortedIPs(testCase.inputIPs)

internal/provider/perfectprivacy/portforward_test.go

@@ -21,7 +21,6 @@ func Test_internalIPToPorts(t *testing.T) {
 	}
 
 	for name, testCase := range testCases {
-		testCase := testCase
 		t.Run(name, func(t *testing.T) {
 			t.Parallel()
 

internal/provider/privateinternetaccess/portforward_test.go

@@ -43,7 +43,6 @@ func Test_unpackPayload(t *testing.T) {
 	}
 
 	for name, testCase := range testCases {
-		testCase := testCase
 		t.Run(name, func(t *testing.T) {
 			t.Parallel()
 			port, token, expiration, err := unpackPayload(testCase.payload)
@@ -97,7 +96,6 @@ func Test_replaceInString(t *testing.T) {
 	}
 
 	for name, testCase := range testCases {
-		testCase := testCase
 		t.Run(name, func(t *testing.T) {
 			t.Parallel()
 			result := replaceInString(testCase.s, testCase.substitutions)

internal/provider/privatevpn/portforward_test.go

@@ -196,7 +196,6 @@ func Test_Provider_PortForward(t *testing.T) {
 		},
 	}
 	for name, testCase := range testCases {
-		testCase := testCase
 		t.Run(name, func(t *testing.T) {
 			t.Parallel()
 

internal/provider/slickvpn/updater/website_test.go

@@ -70,7 +70,6 @@ func Test_fetchServers(t *testing.T) {
 	}
 
 	for name, testCase := range testCases {
-		testCase := testCase
 		t.Run(name, func(t *testing.T) {
 			t.Parallel()
 
@@ -253,7 +252,6 @@ func Test_parseHTML(t *testing.T) {
 	}
 
 	for name, testCase := range testCases {
-		testCase := testCase
 		t.Run(name, func(t *testing.T) {
 			t.Parallel()
 

internal/provider/surfshark/updater/api_test.go

@@ -92,7 +92,6 @@ func Test_addServersFromAPI(t *testing.T) {
 		},
 	}
 	for name, testCase := range testCases {
-		testCase := testCase
 		t.Run(name, func(t *testing.T) {
 			t.Parallel()
 
@@ -206,7 +205,6 @@ func Test_fetchAPI(t *testing.T) {
 		},
 	}
 	for name, testCase := range testCases {
-		testCase := testCase
 		t.Run(name, func(t *testing.T) {
 			t.Parallel()
 

internal/provider/utils/cipher_test.go

@@ -30,7 +30,6 @@ func Test_CipherLines(t *testing.T) {
 		},
 	}
 	for name, testCase := range testCases {
-		testCase := testCase
 		t.Run(name, func(t *testing.T) {
 			t.Parallel()
 

internal/provider/utils/connection_test.go

@@ -185,7 +185,6 @@ func Test_GetConnection(t *testing.T) {
 	}
 
 	for name, testCase := range testCases {
-		testCase := testCase
 		t.Run(name, func(t *testing.T) {
 			t.Parallel()
 			ctrl := gomock.NewController(t)

internal/provider/utils/filtering_test.go

@@ -274,7 +274,6 @@ func Test_FilterServers(t *testing.T) {
 	}
 
 	for name, testCase := range testCases {
-		testCase := testCase
 		t.Run(name, func(t *testing.T) {
 			t.Parallel()
 
@@ -305,7 +304,6 @@ func Test_filterByPossibilities(t *testing.T) {
 	}
 
 	for name, testCase := range testCases {
-		testCase := testCase
 		t.Run(name, func(t *testing.T) {
 			t.Parallel()
 			filtered := filterByPossibilities(testCase.value, testCase.possibilities)

internal/provider/utils/port_test.go

@@ -115,7 +115,6 @@ func Test_GetPort(t *testing.T) {
 	}
 
 	for name, testCase := range testCases {
-		testCase := testCase
 		t.Run(name, func(t *testing.T) {
 			t.Parallel()
 

internal/provider/utils/protocol_test.go

@@ -46,7 +46,6 @@ func Test_getProtocol(t *testing.T) {
 	}
 
 	for name, testCase := range testCases {
-		testCase := testCase
 		t.Run(name, func(t *testing.T) {
 			t.Parallel()
 
@@ -123,7 +122,6 @@ func Test_filterByProtocol(t *testing.T) {
 	}
 
 	for name, testCase := range testCases {
-		testCase := testCase
 		t.Run(name, func(t *testing.T) {
 			t.Parallel()
 

internal/provider/utils/wireguard_test.go

@@ -63,7 +63,6 @@ func Test_BuildWireguardSettings(t *testing.T) {
 	}
 
 	for name, testCase := range testCases {
-		testCase := testCase
 		t.Run(name, func(t *testing.T) {
 			t.Parallel()
 

internal/provider/vpnsecure/updater/website_test.go

@@ -79,7 +79,6 @@ func Test_fetchServers(t *testing.T) {
 	}
 
 	for name, testCase := range testCases {
-		testCase := testCase
 		t.Run(name, func(t *testing.T) {
 			t.Parallel()
 			ctrl := gomock.NewController(t)
@@ -217,7 +216,6 @@ func Test_parseHTML(t *testing.T) {
 	}
 
 	for name, testCase := range testCases {
-		testCase := testCase
 		t.Run(name, func(t *testing.T) {
 			t.Parallel()
 

internal/provider/wevpn/connection_test.go

@@ -82,7 +82,6 @@ func Test_Provider_GetConnection(t *testing.T) {
 	}
 
 	for name, testCase := range testCases {
-		testCase := testCase
 		t.Run(name, func(t *testing.T) {
 			t.Parallel()
 			ctrl := gomock.NewController(t)

internal/provider/windscribe/connection_test.go

@@ -89,7 +89,6 @@ func Test_Provider_GetConnection(t *testing.T) {
 	}
 
 	for name, testCase := range testCases {
-		testCase := testCase
 		t.Run(name, func(t *testing.T) {
 			t.Parallel()
 			ctrl := gomock.NewController(t)