chore(lint): add new linters and update codebase

- add canonicalheader
- add copyloopvar
- add fatcontext
- add intrange

.golangci.yml

@@ -37,7 +37,9 @@ linters:
     - asciicheck
     - bidichk
     - bodyclose
+    - canonicalheader
     - containedctx
+    - copyloopvar
     - decorder
     - dogsled
     - dupl
@@ -47,6 +49,7 @@ linters:
     - errchkjson
     - errname
     - exhaustive
+    - fatcontext
     - forcetypeassert
     - gci
     - gocheckcompilerdirectives
@@ -66,6 +69,7 @@ linters:
     - grouper
     - importas
     - interfacebloat
+    - intrange
     - ireturn
     - lll
     - maintidx

internal/command/run_test.go

@@ -30,7 +30,6 @@ func Test_run(t *testing.T) {
 	}
 
 	for name, testCase := range testCases {
-		testCase := testCase
 		t.Run(name, func(t *testing.T) {
 			t.Parallel()
 

internal/command/start_test.go

@@ -54,7 +54,6 @@ func Test_start(t *testing.T) {
 	}
 
 	for name, testCase := range testCases {
-		testCase := testCase
 		t.Run(name, func(t *testing.T) {
 			t.Parallel()
 

internal/configuration/settings/firewall.go

@@ -104,7 +104,6 @@ func (f Firewall) toLinesNode() (node *gotree.Node) {
 	if len(f.OutboundSubnets) > 0 {
 		outboundSubnets := node.Appendf("Outbound subnets:")
 		for _, subnet := range f.OutboundSubnets {
-			subnet := subnet
 			outboundSubnets.Appendf("%s", &subnet)
 		}
 	}

internal/configuration/settings/firewall_test.go

@@ -59,7 +59,6 @@ func Test_Firewall_validate(t *testing.T) {
 	}
 
 	for name, testCase := range testCases {
-		testCase := testCase
 		t.Run(name, func(t *testing.T) {
 			t.Parallel()
 

internal/configuration/settings/openvpn_test.go

@@ -32,7 +32,6 @@ func Test_ivpnAccountID(t *testing.T) {
 	}
 
 	for _, testCase := range testCases {
-		testCase := testCase
 		t.Run(testCase.s, func(t *testing.T) {
 			t.Parallel()
 

internal/configuration/settings/settings_test.go

@@ -86,7 +86,6 @@ func Test_Settings_String(t *testing.T) {
 	}
 
 	for name, testCase := range testCases {
-		testCase := testCase
 		t.Run(name, func(t *testing.T) {
 			t.Parallel()
 

internal/configuration/sources/files/wireguard_test.go

@@ -73,7 +73,6 @@ PresharedKey = YJ680VN+dGrdsWNjSFqZ6vvwuiNhbq502ZL3G7Q3o3g=
 	}
 
 	for testName, testCase := range testCases {
-		testCase := testCase
 		t.Run(testName, func(t *testing.T) {
 			t.Parallel()
 
@@ -123,7 +122,6 @@ Address = 10.38.22.35/32
 	}
 
 	for testName, testCase := range testCases {
-		testCase := testCase
 		t.Run(testName, func(t *testing.T) {
 			t.Parallel()
 
@@ -184,7 +182,6 @@ Endpoint = 1.2.3.4:51820`,
 	}
 
 	for testName, testCase := range testCases {
-		testCase := testCase
 		t.Run(testName, func(t *testing.T) {
 			t.Parallel()
 

internal/configuration/sources/secrets/reader_test.go

@@ -91,7 +91,6 @@ func Test_Source_Get(t *testing.T) {
 	}
 
 	for name, testCase := range testCases {
-		testCase := testCase
 		t.Run(name, func(t *testing.T) {
 			t.Parallel()
 

internal/firewall/delete_test.go

@@ -38,7 +38,6 @@ func Test_isDeleteMatchInstruction(t *testing.T) {
 		},
 	}
 	for name, testCase := range testCases {
-		testCase := testCase
 		t.Run(name, func(t *testing.T) {
 			t.Parallel()
 
@@ -161,7 +160,6 @@ func Test_deleteIPTablesRule(t *testing.T) {
 	}
 
 	for name, testCase := range testCases {
-		testCase := testCase
 		t.Run(name, func(t *testing.T) {
 			t.Parallel()
 			ctrl := gomock.NewController(t)

internal/firewall/list_test.go

@@ -105,7 +105,6 @@ num pkts bytes target     prot opt in     out     source               destinati
 	}
 
 	for name, testCase := range testCases {
-		testCase := testCase
 		t.Run(name, func(t *testing.T) {
 			t.Parallel()
 

internal/firewall/parse_test.go

@@ -68,7 +68,6 @@ func Test_parseIptablesInstruction(t *testing.T) {
 	}
 
 	for name, testCase := range testCases {
-		testCase := testCase
 		t.Run(name, func(t *testing.T) {
 			t.Parallel()
 
@@ -121,7 +120,6 @@ func Test_parseIPPrefix(t *testing.T) {
 	}
 
 	for name, testCase := range testCases {
-		testCase := testCase
 		t.Run(name, func(t *testing.T) {
 			t.Parallel()
 

internal/firewall/support_test.go

@@ -110,7 +110,6 @@ func Test_checkIptablesSupport(t *testing.T) {
 	}
 
 	for name, testCase := range testCases {
-		testCase := testCase
 		t.Run(name, func(t *testing.T) {
 			t.Parallel()
 			ctrl := gomock.NewController(t)
@@ -249,7 +248,6 @@ func Test_testIptablesPath(t *testing.T) {
 	}
 
 	for name, testCase := range testCases {
-		testCase := testCase
 		t.Run(name, func(t *testing.T) {
 			t.Parallel()
 			ctrl := gomock.NewController(t)
@@ -287,7 +285,6 @@ func Test_isPermissionDenied(t *testing.T) {
 	}
 
 	for name, testCase := range testCases {
-		testCase := testCase
 		t.Run(name, func(t *testing.T) {
 			t.Parallel()
 
@@ -330,7 +327,6 @@ func Test_extractInputPolicy(t *testing.T) {
 	}
 
 	for name, testCase := range testCases {
-		testCase := testCase
 		t.Run(name, func(t *testing.T) {
 			t.Parallel()
 

internal/format/duration_test.go

@@ -54,7 +54,6 @@ func Test_FriendlyDuration(t *testing.T) {
 		},
 	}
 	for name, testCase := range testCases {
-		testCase := testCase
 		t.Run(name, func(t *testing.T) {
 			t.Parallel()
 

internal/healthcheck/health_test.go

@@ -90,7 +90,6 @@ func Test_makeAddressToDial(t *testing.T) {
 	}
 
 	for name, testCase := range testCases {
-		testCase := testCase
 		t.Run(name, func(t *testing.T) {
 			t.Parallel()
 

internal/httpserver/server_test.go

@@ -48,7 +48,6 @@ func Test_New(t *testing.T) {
 	}
 
 	for name, testCase := range testCases {
-		testCase := testCase
 		t.Run(name, func(t *testing.T) {
 			t.Parallel()
 

internal/httpserver/settings_test.go

@@ -44,7 +44,6 @@ func Test_Settings_SetDefaults(t *testing.T) {
 	}
 
 	for name, testCase := range testCases {
-		testCase := testCase
 		t.Run(name, func(t *testing.T) {
 			t.Parallel()
 
@@ -87,7 +86,6 @@ func Test_Settings_Copy(t *testing.T) {
 	}
 
 	for name, testCase := range testCases {
-		testCase := testCase
 		t.Run(name, func(t *testing.T) {
 			t.Parallel()
 
@@ -173,7 +171,6 @@ func Test_Settings_OverrideWith(t *testing.T) {
 	}
 
 	for name, testCase := range testCases {
-		testCase := testCase
 		t.Run(name, func(t *testing.T) {
 			t.Parallel()
 
@@ -263,7 +260,6 @@ func Test_Settings_Validate(t *testing.T) {
 	}
 
 	for name, testCase := range testCases {
-		testCase := testCase
 		t.Run(name, func(t *testing.T) {
 			t.Parallel()
 
@@ -300,7 +296,6 @@ func Test_Settings_String(t *testing.T) {
 	}
 
 	for name, testCase := range testCases {
-		testCase := testCase
 		t.Run(name, func(t *testing.T) {
 			t.Parallel()
 

internal/models/markdown_test.go

@@ -52,7 +52,6 @@ func Test_Servers_ToMarkdown(t *testing.T) {
 	}
 
 	for name, testCase := range testCases {
-		testCase := testCase
 		t.Run(name, func(t *testing.T) {
 			t.Parallel()
 

internal/models/server_test.go

@@ -103,7 +103,6 @@ func Test_Server_Equal(t *testing.T) {
 	}
 
 	for name, testCase := range testCases {
-		testCase := testCase
 		t.Run(name, func(t *testing.T) {
 			t.Parallel()
 

internal/models/servers_test.go

@@ -54,7 +54,6 @@ func Test_AllServers_MarshalJSON(t *testing.T) {
 	}
 
 	for name, testCase := range testCases {
-		testCase := testCase
 		t.Run(name, func(t *testing.T) {
 			t.Parallel()
 
@@ -124,7 +123,6 @@ func Test_AllServers_UnmarshalJSON(t *testing.T) {
 	}
 
 	for name, testCase := range testCases {
-		testCase := testCase
 		t.Run(name, func(t *testing.T) {
 			t.Parallel()
 

internal/natpmp/checks_test.go

@@ -25,7 +25,6 @@ func Test_checkRequest(t *testing.T) {
 	}
 
 	for name, testCase := range testCases {
-		testCase := testCase
 		t.Run(name, func(t *testing.T) {
 			t.Parallel()
 
@@ -88,7 +87,6 @@ func Test_checkResponse(t *testing.T) {
 	}
 
 	for name, testCase := range testCases {
-		testCase := testCase
 		t.Run(name, func(t *testing.T) {
 			t.Parallel()
 
@@ -146,7 +144,6 @@ func Test_checkResultCode(t *testing.T) {
 	}
 
 	for name, testCase := range testCases {
-		testCase := testCase
 		t.Run(name, func(t *testing.T) {
 			t.Parallel()
 

internal/natpmp/externaladdress_test.go

@@ -46,7 +46,6 @@ func Test_Client_ExternalAddress(t *testing.T) {
 	}
 
 	for name, testCase := range testCases {
-		testCase := testCase
 		t.Run(name, func(t *testing.T) {
 			t.Parallel()
 

internal/natpmp/portmapping_test.go

@@ -115,7 +115,6 @@ func Test_Client_AddPortMapping(t *testing.T) {
 	}
 
 	for name, testCase := range testCases {
-		testCase := testCase
 		t.Run(name, func(t *testing.T) {
 			t.Parallel()
 

internal/natpmp/rpc.go

@@ -69,7 +69,7 @@ func (c *Client) rpc(ctx context.Context, gateway netip.Addr,
 
 	var retryCount uint
 	var failedAttempts []string
-	for retryCount = 0; retryCount < c.maxRetries; retryCount++ {
+	for retryCount = 0; retryCount < c.maxRetries; retryCount++ { //nolint:intrange
 		deadline := time.Now().Add(connectionDuration)
 		err = connection.SetDeadline(deadline)
 		if err != nil {

internal/natpmp/rpc_test.go

@@ -138,7 +138,6 @@ func Test_Client_rpc(t *testing.T) {
 	}
 
 	for name, testCase := range testCases {
-		testCase := testCase
 		t.Run(name, func(t *testing.T) {
 			t.Parallel()
 
@@ -193,7 +192,6 @@ func Test_dedupFailedAttempts(t *testing.T) {
 	}
 
 	for name, testCase := range testCases {
-		testCase := testCase
 		t.Run(name, func(t *testing.T) {
 			t.Parallel()
 

internal/netlink/conversion_test.go

@@ -42,7 +42,6 @@ func Test_netipPrefixToIPNet(t *testing.T) {
 	}
 
 	for name, testCase := range testCases {
-		testCase := testCase
 		t.Run(name, func(t *testing.T) {
 			t.Parallel()
 
@@ -90,7 +89,6 @@ func Test_netIPNetToNetipPrefix(t *testing.T) {
 	}
 
 	for name, testCase := range testCases {
-		testCase := testCase
 		t.Run(name, func(t *testing.T) {
 			t.Parallel()
 
@@ -128,7 +126,6 @@ func Test_netIPToNetipAddress(t *testing.T) {
 	}
 
 	for name, testCase := range testCases {
-		testCase := testCase
 		t.Run(name, func(t *testing.T) {
 			t.Parallel()
 

internal/openvpn/extract/extract_test.go

@@ -65,7 +65,6 @@ func Test_extractDataFromLines(t *testing.T) {
 	}
 
 	for name, testCase := range testCases {
-		testCase := testCase
 		t.Run(name, func(t *testing.T) {
 			t.Parallel()
 
@@ -129,7 +128,6 @@ func Test_extractDataFromLine(t *testing.T) {
 	}
 
 	for name, testCase := range testCases {
-		testCase := testCase
 		t.Run(name, func(t *testing.T) {
 			t.Parallel()
 
@@ -175,7 +173,6 @@ func Test_extractProto(t *testing.T) {
 	}
 
 	for name, testCase := range testCases {
-		testCase := testCase
 		t.Run(name, func(t *testing.T) {
 			t.Parallel()
 
@@ -253,7 +250,6 @@ func Test_extractRemote(t *testing.T) {
 	}
 
 	for name, testCase := range testCases {
-		testCase := testCase
 		t.Run(name, func(t *testing.T) {
 			t.Parallel()
 

internal/openvpn/extract/pem_test.go

@@ -40,7 +40,6 @@ func Test_PEM(t *testing.T) {
 	}
 
 	for name, testCase := range testCases {
-		testCase := testCase
 		t.Run(name, func(t *testing.T) {
 			t.Parallel()
 

internal/openvpn/logs_test.go

@@ -75,7 +75,6 @@ That error usually happens because either:
 		},
 	}
 	for name, tc := range tests {
-		tc := tc
 		t.Run(name, func(t *testing.T) {
 			t.Parallel()
 			filtered, level := processLogLine(tc.s)

internal/openvpn/pkcs8/algorithms_test.go

@@ -86,7 +86,6 @@ func Test_getEncryptionAlgorithmOid(t *testing.T) {
 	}
 
 	for name, testCase := range testCases {
-		testCase := testCase
 		t.Run(name, func(t *testing.T) {
 			t.Parallel()
 

internal/openvpn/pkcs8/upgrade_test.go

@@ -48,7 +48,6 @@ func Test_UpgradeEncryptedKey(t *testing.T) {
 	}
 
 	for name, testCase := range testCases {
-		testCase := testCase
 		t.Run(name, func(t *testing.T) {
 			t.Parallel()
 

internal/portforward/service/helpers_test.go

@@ -31,7 +31,6 @@ func Test_portsToString(t *testing.T) {
 	}
 
 	for name, testCase := range testCases {
-		testCase := testCase
 		t.Run(name, func(t *testing.T) {
 			t.Parallel()
 

internal/pprof/settings_test.go

@@ -55,7 +55,6 @@ func Test_Settings_SetDefaults(t *testing.T) {
 	}
 
 	for name, testCase := range testCases {
-		testCase := testCase
 		t.Run(name, func(t *testing.T) {
 			t.Parallel()
 
@@ -97,7 +96,6 @@ func Test_Settings_Copy(t *testing.T) {
 	}
 
 	for name, testCase := range testCases {
-		testCase := testCase
 		t.Run(name, func(t *testing.T) {
 			t.Parallel()
 
@@ -182,7 +180,6 @@ func Test_Settings_OverrideWith(t *testing.T) {
 	}
 
 	for name, testCase := range testCases {
-		testCase := testCase
 		t.Run(name, func(t *testing.T) {
 			t.Parallel()
 
@@ -245,7 +242,6 @@ func Test_Settings_Validate(t *testing.T) {
 	}
 
 	for name, testCase := range testCases {
-		testCase := testCase
 		t.Run(name, func(t *testing.T) {
 			t.Parallel()
 
@@ -293,7 +289,6 @@ func Test_Settings_String(t *testing.T) {
 	}
 
 	for name, testCase := range testCases {
-		testCase := testCase
 		t.Run(name, func(t *testing.T) {
 			t.Parallel()
 

internal/provider/custom/openvpnconf_test.go

@@ -79,7 +79,6 @@ func Test_modifyConfig(t *testing.T) {
 	}
 
 	for name, testCase := range testCases {
-		testCase := testCase
 		t.Run(name, func(t *testing.T) {
 			t.Parallel()
 

internal/provider/expressvpn/connection_test.go

@@ -77,7 +77,6 @@ func Test_Provider_GetConnection(t *testing.T) {
 	}
 
 	for name, testCase := range testCases {
-		testCase := testCase
 		t.Run(name, func(t *testing.T) {
 			t.Parallel()
 			ctrl := gomock.NewController(t)

internal/provider/fastestvpn/updater/api.go

@@ -77,7 +77,7 @@ func fetchAPIServers(ctx context.Context, client *http.Client, protocol string)
 		var server apiServer
 
 		const numberOfTDBlocks = 3
-		for i := 0; i < numberOfTDBlocks; i++ {
+		for i := range numberOfTDBlocks {
 			tdBlock := getNextTDBlock(trBlock)
 			if tdBlock == nil {
 				return nil, fmt.Errorf("%w: expected 3 <td> blocks in <tr> block %q",

internal/provider/fastestvpn/updater/api_test.go

@@ -89,7 +89,6 @@ func Test_fechAPIServers(t *testing.T) {
 	}
 
 	for name, testCase := range testCases {
-		testCase := testCase
 		t.Run(name, func(t *testing.T) {
 			t.Parallel()
 
@@ -152,7 +151,6 @@ func Test_getNextBlock(t *testing.T) {
 	}
 
 	for name, testCase := range testCases {
-		testCase := testCase
 		t.Run(name, func(t *testing.T) {
 			t.Parallel()
 

internal/provider/ipvanish/updater/filename_test.go

@@ -37,7 +37,6 @@ func Test_parseFilename(t *testing.T) {
 		},
 	}
 	for name, testCase := range testCases {
-		testCase := testCase
 		t.Run(name, func(t *testing.T) {
 			t.Parallel()
 

internal/provider/ipvanish/updater/hosttoserver_test.go

@@ -87,7 +87,6 @@ func Test_hostToServer_add(t *testing.T) {
 		},
 	}
 	for name, testCase := range testCases {
-		testCase := testCase
 		t.Run(name, func(t *testing.T) {
 			t.Parallel()
 			testCase.initialHTS.add(testCase.host, testCase.country, testCase.city, testCase.tcp, testCase.udp)
@@ -121,7 +120,6 @@ func Test_hostToServer_toHostsSlice(t *testing.T) {
 		},
 	}
 	for name, testCase := range testCases {
-		testCase := testCase
 		t.Run(name, func(t *testing.T) {
 			t.Parallel()
 			hosts := testCase.hts.toHostsSlice()
@@ -175,7 +173,6 @@ func Test_hostToServer_adaptWithIPs(t *testing.T) {
 		},
 	}
 	for name, testCase := range testCases {
-		testCase := testCase
 		t.Run(name, func(t *testing.T) {
 			t.Parallel()
 			testCase.initialHTS.adaptWithIPs(testCase.hostToIPs)
@@ -206,7 +203,6 @@ func Test_hostToServer_toServersSlice(t *testing.T) {
 		},
 	}
 	for name, testCase := range testCases {
-		testCase := testCase
 		t.Run(name, func(t *testing.T) {
 			t.Parallel()
 			servers := testCase.hts.toServersSlice()

internal/provider/ipvanish/updater/servers_test.go

@@ -187,7 +187,6 @@ func Test_Updater_GetServers(t *testing.T) {
 		},
 	}
 	for name, testCase := range testCases {
-		testCase := testCase
 		t.Run(name, func(t *testing.T) {
 			t.Parallel()
 			ctrl := gomock.NewController(t)

internal/provider/ivpn/connection_test.go

@@ -88,7 +88,6 @@ func Test_Provider_GetConnection(t *testing.T) {
 	}
 
 	for name, testCase := range testCases {
-		testCase := testCase
 		t.Run(name, func(t *testing.T) {
 			t.Parallel()
 			ctrl := gomock.NewController(t)

internal/provider/ivpn/updater/api_test.go

@@ -63,7 +63,6 @@ func Test_fetchAPI(t *testing.T) {
 		},
 	}
 	for name, testCase := range testCases {
-		testCase := testCase
 		t.Run(name, func(t *testing.T) {
 			t.Parallel()
 

internal/provider/ivpn/updater/servers_test.go

@@ -131,7 +131,6 @@ func Test_Updater_GetServers(t *testing.T) {
 		},
 	}
 	for name, testCase := range testCases {
-		testCase := testCase
 		t.Run(name, func(t *testing.T) {
 			t.Parallel()
 			ctrl := gomock.NewController(t)

internal/provider/mullvad/connection_test.go

@@ -88,7 +88,6 @@ func Test_Provider_GetConnection(t *testing.T) {
 	}
 
 	for name, testCase := range testCases {
-		testCase := testCase
 		t.Run(name, func(t *testing.T) {
 			t.Parallel()
 			ctrl := gomock.NewController(t)

internal/provider/mullvad/updater/ips_test.go

@@ -31,7 +31,6 @@ func Test_uniqueSortedIPs(t *testing.T) {
 		},
 	}
 	for name, testCase := range testCases {
-		testCase := testCase
 		t.Run(name, func(t *testing.T) {
 			t.Parallel()
 			outputIPs := uniqueSortedIPs(testCase.inputIPs)

internal/provider/perfectprivacy/portforward_test.go

@@ -21,7 +21,6 @@ func Test_internalIPToPorts(t *testing.T) {
 	}
 
 	for name, testCase := range testCases {
-		testCase := testCase
 		t.Run(name, func(t *testing.T) {
 			t.Parallel()
 

internal/provider/privateinternetaccess/portforward_test.go

@@ -43,7 +43,6 @@ func Test_unpackPayload(t *testing.T) {
 	}
 
 	for name, testCase := range testCases {
-		testCase := testCase
 		t.Run(name, func(t *testing.T) {
 			t.Parallel()
 			port, token, expiration, err := unpackPayload(testCase.payload)
@@ -97,7 +96,6 @@ func Test_replaceInString(t *testing.T) {
 	}
 
 	for name, testCase := range testCases {
-		testCase := testCase
 		t.Run(name, func(t *testing.T) {
 			t.Parallel()
 			result := replaceInString(testCase.s, testCase.substitutions)

internal/provider/privatevpn/portforward_test.go

@@ -196,7 +196,6 @@ func Test_Provider_PortForward(t *testing.T) {
 		},
 	}
 	for name, testCase := range testCases {
-		testCase := testCase
 		t.Run(name, func(t *testing.T) {
 			t.Parallel()
 

internal/provider/slickvpn/updater/website_test.go

@@ -70,7 +70,6 @@ func Test_fetchServers(t *testing.T) {
 	}
 
 	for name, testCase := range testCases {
-		testCase := testCase
 		t.Run(name, func(t *testing.T) {
 			t.Parallel()
 
@@ -253,7 +252,6 @@ func Test_parseHTML(t *testing.T) {
 	}
 
 	for name, testCase := range testCases {
-		testCase := testCase
 		t.Run(name, func(t *testing.T) {
 			t.Parallel()
 

internal/provider/surfshark/updater/api_test.go

@@ -92,7 +92,6 @@ func Test_addServersFromAPI(t *testing.T) {
 		},
 	}
 	for name, testCase := range testCases {
-		testCase := testCase
 		t.Run(name, func(t *testing.T) {
 			t.Parallel()
 
@@ -206,7 +205,6 @@ func Test_fetchAPI(t *testing.T) {
 		},
 	}
 	for name, testCase := range testCases {
-		testCase := testCase
 		t.Run(name, func(t *testing.T) {
 			t.Parallel()
 

internal/provider/utils/cipher_test.go

@@ -30,7 +30,6 @@ func Test_CipherLines(t *testing.T) {
 		},
 	}
 	for name, testCase := range testCases {
-		testCase := testCase
 		t.Run(name, func(t *testing.T) {
 			t.Parallel()
 

internal/provider/utils/connection_test.go

@@ -185,7 +185,6 @@ func Test_GetConnection(t *testing.T) {
 	}
 
 	for name, testCase := range testCases {
-		testCase := testCase
 		t.Run(name, func(t *testing.T) {
 			t.Parallel()
 			ctrl := gomock.NewController(t)

internal/provider/utils/filtering_test.go

@@ -274,7 +274,6 @@ func Test_FilterServers(t *testing.T) {
 	}
 
 	for name, testCase := range testCases {
-		testCase := testCase
 		t.Run(name, func(t *testing.T) {
 			t.Parallel()
 
@@ -305,7 +304,6 @@ func Test_filterByPossibilities(t *testing.T) {
 	}
 
 	for name, testCase := range testCases {
-		testCase := testCase
 		t.Run(name, func(t *testing.T) {
 			t.Parallel()
 			filtered := filterByPossibilities(testCase.value, testCase.possibilities)

internal/provider/utils/port_test.go

@@ -115,7 +115,6 @@ func Test_GetPort(t *testing.T) {
 	}
 
 	for name, testCase := range testCases {
-		testCase := testCase
 		t.Run(name, func(t *testing.T) {
 			t.Parallel()
 

internal/provider/utils/protocol_test.go

@@ -46,7 +46,6 @@ func Test_getProtocol(t *testing.T) {
 	}
 
 	for name, testCase := range testCases {
-		testCase := testCase
 		t.Run(name, func(t *testing.T) {
 			t.Parallel()
 
@@ -123,7 +122,6 @@ func Test_filterByProtocol(t *testing.T) {
 	}
 
 	for name, testCase := range testCases {
-		testCase := testCase
 		t.Run(name, func(t *testing.T) {
 			t.Parallel()
 

internal/provider/utils/wireguard_test.go

@@ -63,7 +63,6 @@ func Test_BuildWireguardSettings(t *testing.T) {
 	}
 
 	for name, testCase := range testCases {
-		testCase := testCase
 		t.Run(name, func(t *testing.T) {
 			t.Parallel()
 

internal/provider/vpnsecure/updater/website_test.go

@@ -79,7 +79,6 @@ func Test_fetchServers(t *testing.T) {
 	}
 
 	for name, testCase := range testCases {
-		testCase := testCase
 		t.Run(name, func(t *testing.T) {
 			t.Parallel()
 			ctrl := gomock.NewController(t)
@@ -217,7 +216,6 @@ func Test_parseHTML(t *testing.T) {
 	}
 
 	for name, testCase := range testCases {
-		testCase := testCase
 		t.Run(name, func(t *testing.T) {
 			t.Parallel()
 

internal/provider/wevpn/connection_test.go

@@ -82,7 +82,6 @@ func Test_Provider_GetConnection(t *testing.T) {
 	}
 
 	for name, testCase := range testCases {
-		testCase := testCase
 		t.Run(name, func(t *testing.T) {
 			t.Parallel()
 			ctrl := gomock.NewController(t)

internal/provider/windscribe/connection_test.go

@@ -89,7 +89,6 @@ func Test_Provider_GetConnection(t *testing.T) {
 	}
 
 	for name, testCase := range testCases {
-		testCase := testCase
 		t.Run(name, func(t *testing.T) {
 			t.Parallel()
 			ctrl := gomock.NewController(t)

internal/publicip/api/multi.go

@@ -35,7 +35,7 @@ func FetchMultiInfo(ctx context.Context, fetcher Fetcher, ips []netip.Addr) (
 	}
 
 	results = make([]models.PublicIP, len(ips))
-	for i := 0; i < len(ips); i++ {
+	for range len(ips) {
 		aResult := <-resultsCh
 		if aResult.err != nil {
 			if err == nil {

internal/routing/conversion_test.go

@@ -34,7 +34,6 @@ func Test_netIPToNetipAddress(t *testing.T) {
 	}
 
 	for name, testCase := range testCases {
-		testCase := testCase
 		t.Run(name, func(t *testing.T) {
 			t.Parallel()
 

internal/routing/ip_test.go

@@ -83,7 +83,6 @@ func Test_ipIsPrivate(t *testing.T) {
 		},
 	}
 	for name, testCase := range testCases {
-		testCase := testCase
 		t.Run(name, func(t *testing.T) {
 			t.Parallel()
 

internal/routing/rules_test.go

@@ -105,7 +105,6 @@ func Test_Routing_addIPRule(t *testing.T) {
 	}
 
 	for name, testCase := range testCases {
-		testCase := testCase
 		t.Run(name, func(t *testing.T) {
 			t.Parallel()
 			ctrl := gomock.NewController(t)
@@ -223,7 +222,6 @@ func Test_Routing_deleteIPRule(t *testing.T) {
 	}
 
 	for name, testCase := range testCases {
-		testCase := testCase
 		t.Run(name, func(t *testing.T) {
 			t.Parallel()
 			ctrl := gomock.NewController(t)
@@ -289,7 +287,6 @@ func Test_ruleDbgMsg(t *testing.T) {
 	}
 
 	for name, testCase := range testCases {
-		testCase := testCase
 		t.Run(name, func(t *testing.T) {
 			t.Parallel()
 
@@ -386,7 +383,6 @@ func Test_rulesAreEqual(t *testing.T) {
 	}
 
 	for name, testCase := range testCases {
-		testCase := testCase
 		t.Run(name, func(t *testing.T) {
 			t.Parallel()
 
@@ -434,7 +430,6 @@ func Test_ipPrefixesAreEqual(t *testing.T) {
 	}
 
 	for name, testCase := range testCases {
-		testCase := testCase
 		t.Run(name, func(t *testing.T) {
 			t.Parallel()
 

internal/server/middlewares/auth/apikey.go

@@ -27,7 +27,7 @@ func (a *apiKeyMethod) equal(other authorizationChecker) bool {
 }
 
 func (a *apiKeyMethod) isAuthorized(_ http.Header, request *http.Request) bool {
-	xAPIKey := request.Header.Get("X-API-Key")
+	xAPIKey := request.Header.Get("X-API-Key") //nolint:canonicalheader
 	if xAPIKey == "" {
 		xAPIKey = request.URL.Query().Get("api_key")
 	}

internal/server/middlewares/auth/configfile_test.go

@@ -57,7 +57,6 @@ routes = ["GET /v1/vpn/status"]
 	}
 
 	for name, testCase := range testCases {
-		testCase := testCase
 		t.Run(name, func(t *testing.T) {
 			t.Parallel()
 

internal/server/middlewares/auth/lookup_test.go

@@ -44,7 +44,6 @@ func Test_settingsToLookupMap(t *testing.T) {
 	}
 
 	for name, testCase := range testCases {
-		testCase := testCase
 		t.Run(name, func(t *testing.T) {
 			t.Parallel()
 

internal/server/middlewares/auth/middleware_test.go

@@ -80,7 +80,6 @@ func Test_authHandler_ServeHTTP(t *testing.T) {
 	}
 
 	for name, testCase := range testCases {
-		testCase := testCase
 		t.Run(name, func(t *testing.T) {
 			t.Parallel()
 			ctrl := gomock.NewController(t)

internal/storage/copy_test.go

@@ -47,7 +47,6 @@ func Test_copyIPs(t *testing.T) {
 	}
 
 	for name, testCase := range testCases {
-		testCase := testCase
 		t.Run(name, func(t *testing.T) {
 			t.Parallel()
 

internal/storage/read_test.go

@@ -91,7 +91,6 @@ func Test_extractServersFromBytes(t *testing.T) {
 	}
 
 	for name, testCase := range testCases {
-		testCase := testCase
 		t.Run(name, func(t *testing.T) {
 			t.Parallel()
 			ctrl := gomock.NewController(t)

internal/updater/html/fetch_test.go

@@ -63,7 +63,6 @@ func Test_Fetch(t *testing.T) {
 	}
 
 	for name, testCase := range testCases {
-		testCase := testCase
 		t.Run(name, func(t *testing.T) {
 			t.Parallel()
 

internal/updater/resolver/ips_test.go

@@ -31,7 +31,6 @@ func Test_uniqueIPsToSlice(t *testing.T) {
 		},
 	}
 	for name, testCase := range testCases {
-		testCase := testCase
 		t.Run(name, func(t *testing.T) {
 			t.Parallel()
 			outputIPs := uniqueIPsToSlice(testCase.inputIPs)

internal/wireguard/address_test.go

@@ -94,7 +94,6 @@ func Test_Wireguard_addAddresses(t *testing.T) {
 	}
 
 	for name, testCase := range testCases {
-		testCase := testCase
 		t.Run(name, func(t *testing.T) {
 			t.Parallel()
 			ctrl := gomock.NewController(t)

internal/wireguard/config_test.go

@@ -93,7 +93,6 @@ func Test_makeDeviceConfig(t *testing.T) {
 	}
 
 	for name, testCase := range testCases {
-		testCase := testCase
 		t.Run(name, func(t *testing.T) {
 			t.Parallel()
 

internal/wireguard/constructor_test.go

@@ -61,7 +61,6 @@ func Test_New(t *testing.T) {
 	}
 
 	for name, testCase := range testCases {
-		testCase := testCase
 		t.Run(name, func(t *testing.T) {
 			t.Parallel()
 

internal/wireguard/route_test.go

@@ -57,7 +57,6 @@ func Test_Wireguard_addRoute(t *testing.T) {
 	}
 
 	for name, testCase := range testCases {
-		testCase := testCase
 		t.Run(name, func(t *testing.T) {
 			t.Parallel()
 			ctrl := gomock.NewController(t)

internal/wireguard/rule_test.go

@@ -61,7 +61,6 @@ func Test_Wireguard_addRule(t *testing.T) {
 	}
 
 	for name, testCase := range testCases {
-		testCase := testCase
 		t.Run(name, func(t *testing.T) {
 			t.Parallel()
 			ctrl := gomock.NewController(t)

internal/wireguard/settings_test.go

@@ -64,7 +64,6 @@ func Test_Settings_SetDefaults(t *testing.T) {
 	}
 
 	for name, testCase := range testCases {
-		testCase := testCase
 		t.Run(name, func(t *testing.T) {
 			t.Parallel()
 
@@ -293,7 +292,6 @@ func Test_Settings_Check(t *testing.T) {
 	}
 
 	for name, testCase := range testCases {
-		testCase := testCase
 		t.Run(name, func(t *testing.T) {
 			t.Parallel()
 
@@ -434,7 +432,6 @@ func Test_Settings_Lines(t *testing.T) {
 	}
 
 	for name, testCase := range testCases {
-		testCase := testCase
 		t.Run(name, func(t *testing.T) {
 			t.Parallel()