diff --git a/cl/compile.go b/cl/compile.go index 2f770667..d9381137 100644 --- a/cl/compile.go +++ b/cl/compile.go @@ -151,7 +151,7 @@ func (p *context) isStringPtrType(typ types.Type) bool { if !ok { return false } - basic, ok := ptr.Elem().Underlying().(*types.Basic) + basic, ok := ptr.Elem().(*types.Basic) return ok && basic.Kind() == types.String } diff --git a/cl/rewrite_internal_test.go b/cl/rewrite_internal_test.go index 041c6058..8fbf89a3 100644 --- a/cl/rewrite_internal_test.go +++ b/cl/rewrite_internal_test.go @@ -153,3 +153,17 @@ var VarStruct = wrapper{v: 1} t.Fatalf("non-string variables must not be rewritten:\n%s", ir) } } + +func TestRewriteIgnoresStringAlias(t *testing.T) { + const src = `package rewritepkg +type T string +var VarAlias T = "original_value" +` + ir := compileWithRewrites(t, src, map[string]string{"VarAlias": "rewrite_alias"}) + if strings.Contains(ir, `c"rewrite_alias"`) { + t.Fatalf("string alias types must not be rewritten:\n%s", ir) + } + if !strings.Contains(ir, `c"original_value"`) { + t.Fatalf("original value should remain for alias type:\n%s", ir) + } +}