fix: check needStart by libc name

internal/build/build.go

@@ -839,15 +839,16 @@ func isWasmTarget(goos string) bool {
 	return slices.Contains([]string{"wasi", "js", "wasip1"}, goos)
 }
 
-func needStart(conf *Config) bool {
+func needStart(ctx *context) bool {
-	if conf.Target == "" {
+	if ctx.buildConf.Target == "" {
-		return !isWasmTarget(conf.Goos)
+		return !isWasmTarget(ctx.buildConf.Goos)
 	}
-	switch conf.Target {
+	switch ctx.buildConf.Target {
 	case "wasip2":
 		return false
 	default:
-		return true
+		// since newlib-esp32 provides _start, we don't need to provide a fake _start function
+		return ctx.crossCompile.Libc != "newlib-esp32"
 	}
 }
 
@@ -904,10 +905,10 @@ define weak void @_start() {
 }
 `
 	mainDefine := "define i32 @main(i32 noundef %0, ptr nocapture noundef readnone %1) local_unnamed_addr"
-	if !needStart(ctx.buildConf) && isWasmTarget(ctx.buildConf.Goos) {
+	if !needStart(ctx) && isWasmTarget(ctx.buildConf.Goos) {
 		mainDefine = "define hidden noundef i32 @__main_argc_argv(i32 noundef %0, ptr nocapture noundef readnone %1) local_unnamed_addr"
 	}
-	if true {
+	if !needStart(ctx) {
 		startDefine = ""
 	}
 	mainCode := fmt.Sprintf(`; ModuleID = 'main'

internal/crosscompile/compile/libc/newlibesp.go

@@ -25,6 +25,7 @@ func GetNewlibESP32Config(baseDir, arch string) *compile.CompileConfig {
 					filepath.Join(baseDir, "libgloss", "xtensa", "boards", "esp32", "board.c"),
 					filepath.Join(baseDir, "libgloss", "xtensa", "crt1-boards.S"),
 					filepath.Join(baseDir, "libgloss", "xtensa", "sleep.S"),
+					filepath.Join(baseDir, "libgloss", "xtensa", "window-vectors.S"),
 				},
 				CFlags: []string{
 					"-DHAVE_CONFIG_H",

targets/esp32.rom.newlib-funcs.ld

@@ -1,130 +0,0 @@
-/* These are the newlib functions present in ESP32 ROM.
-   They should not be used when compiling with PSRAM cache workaround enabled.
-   See also esp32.rom.newlib-data.ld for the list of .data/.bss symbols
-   used by these functions, and esp32.rom.newlib-nano.ld for "nano" versions
-   of printf/scanf family of functions.
-
-   Unlike other ROM functions which are exported using PROVIDE, which declares
-   weak symbols, newlib related functions are exported using assignment,
-   which declares strong symbols. This is done so that ROM functions are always
-   used instead of the ones provided by libc.a.
-
-   Time functions were moved to the esp32.rom.newlib-time.ld file.
- */
-
-abs = 0x40056340;
-__ascii_wctomb = 0x40058ef0;
-atoi = 0x400566c4;
-_atoi_r = 0x400566d4;
-atol = 0x400566ec;
-_atol_r = 0x400566fc;
-bzero = 0x4000c1f4;
-_cleanup = 0x40001df8;
-_cleanup_r = 0x40001d48;
-creat = 0x40000e8c;
-div = 0x40056348;
-__dummy_lock = 0x4000c728;
-__dummy_lock_try = 0x4000c730;
-__env_lock = 0x40001fd4;
-__env_unlock = 0x40001fe0;
-fclose = 0x400020ac;
-_fclose_r = 0x40001fec;
-fflush = 0x40059394;
-_fflush_r = 0x40059320;
-_findenv_r = 0x40001f44;
-__fp_lock_all = 0x40001f1c;
-__fp_unlock_all = 0x40001f30;
-__fputwc = 0x40058da0;
-fputwc = 0x40058ea8;
-_fputwc_r = 0x40058e4c;
-_fwalk = 0x4000c738;
-_fwalk_reent = 0x4000c770;
-_getenv_r = 0x40001fbc;
-isalnum = 0x40000f04;
-isalpha = 0x40000f18;
-isascii = 0x4000c20c;
-isblank = 0x40000f2c;
-iscntrl = 0x40000f50;
-isdigit = 0x40000f64;
-isgraph = 0x40000f94;
-islower = 0x40000f78;
-isprint = 0x40000fa8;
-ispunct = 0x40000fc0;
-isspace = 0x40000fd4;
-isupper = 0x40000fe8;
-__itoa = 0x40056678;
-itoa = 0x400566b4;
-labs = 0x40056370;
-ldiv = 0x40056378;
-longjmp = 0x400562cc;
-memccpy = 0x4000c220;
-memchr = 0x4000c244;
-memcmp = 0x4000c260;
-memcpy = 0x4000c2c8;
-memmove = 0x4000c3c0;
-memrchr = 0x4000c400;
-memset = 0x4000c44c;
-qsort = 0x40056424;
-rand = 0x40001058;
-rand_r = 0x400010d4;
-__sccl = 0x4000c498;
-__sclose = 0x400011b8;
-__seofread = 0x40001148;
-setjmp = 0x40056268;
-__sflush_r = 0x400591e0;
-__sfmoreglue = 0x40001dc8;
-__sfp = 0x40001e90;
-__sfp_lock_acquire = 0x40001e08;
-__sfp_lock_release = 0x40001e14;
-__sinit = 0x40001e38;
-__sinit_lock_acquire = 0x40001e20;
-__sinit_lock_release = 0x40001e2c;
-srand = 0x40001004;
-__sread = 0x40001118;
-__sseek = 0x40001184;
-strcasecmp = 0x400011cc;
-strcasestr = 0x40001210;
-strcat = 0x4000c518;
-strchr = 0x4000c53c;
-strcmp = 0x40001274;
-strcoll = 0x40001398;
-strcpy = 0x400013ac;
-strcspn = 0x4000c558;
-strdup = 0x4000143c;
-_strdup_r = 0x40001450;
-strlcat = 0x40001470;
-strlcpy = 0x4000c584;
-strlen = 0x400014c0;
-strlwr = 0x40001524;
-strncasecmp = 0x40001550;
-strncat = 0x4000c5c4;
-strncmp = 0x4000c5f4;
-strncpy = 0x400015d4;
-strndup = 0x400016b0;
-_strndup_r = 0x400016c4;
-strnlen = 0x4000c628;
-strrchr = 0x40001708;
-strsep = 0x40001734;
-strspn = 0x4000c648;
-strstr = 0x4000c674;
-__strtok_r = 0x4000c6a8;
-strtok_r = 0x4000c70c;
-strtol = 0x4005681c;
-_strtol_r = 0x40056714;
-strtoul = 0x4005692c;
-_strtoul_r = 0x40056834;
-strupr = 0x4000174c;
-__submore = 0x40058f3c;
-__swbuf = 0x40058cb4;
-__swbuf_r = 0x40058bec;
-__swrite = 0x40001150;
-toascii = 0x4000c720;
-tolower = 0x40001868;
-toupper = 0x40001884;
-ungetc = 0x400590f4;
-_ungetc_r = 0x40058fa0;
-__utoa = 0x400561f0;
-utoa = 0x40056258;
-wcrtomb = 0x40058920;
-_wcrtomb_r = 0x400588d8;
-_wctomb_r = 0x40058f14;