admin/llgo
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix cross compilation tests

Browse Source
This commit is contained in:
Li Jie
2025-08-21 17:01:45 +08:00
parent 21189f378e
commit 5cfd996659
1 changed files with 27 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

33
internal/crosscompile/crosscompile_test.go
View File

@@ -37,10 +37,10 @@ func TestUseCrossCompileSDK(t *testing.T) {
name: "Same Platform", name: "Same Platform",
goos: runtime.GOOS, goos: runtime.GOOS,
goarch: runtime.GOARCH, goarch: runtime.GOARCH,
expectSDK: false, expectSDK: true, // Changed: now we expect flags even for same platform
expectCCFlags: false, expectCCFlags: true, // Changed: CCFLAGS will contain sysroot
expectCFlags: false, expectCFlags: true, // Changed: CFLAGS will contain include paths
expectLDFlags: false, expectLDFlags: true, // Changed: LDFLAGS will contain library paths
}, },
{ {
name: "WASM Target", name: "WASM Target",
@@ -55,10 +55,10 @@ func TestUseCrossCompileSDK(t *testing.T) {
name: "Unsupported Target", name: "Unsupported Target",
goos: "windows", goos: "windows",
goarch: "amd64", goarch: "amd64",
expectSDK: false, expectSDK: false, // Still false as it won't set up specific SDK
expectCCFlags: false, expectCCFlags: false, // No cross-compile specific flags
expectCFlags: false, expectCFlags: false, // No cross-compile specific flags
expectLDFlags: false, expectLDFlags: false, // No cross-compile specific flags
}, },
} }
@@ -111,12 +111,21 @@ func TestUseCrossCompileSDK(t *testing.T) {
} }
} }
// For WASM target, both sysroot and resource-dir are expected
if tc.name == "WASM Target" {
if !hasSysroot { if !hasSysroot {
t.Error("Missing --sysroot flag in CCFLAGS") t.Error("Missing --sysroot flag in CCFLAGS")
} }
if !hasResourceDir { if !hasResourceDir {
t.Error("Missing -resource-dir flag in CCFLAGS") t.Error("Missing -resource-dir flag in CCFLAGS")
} }
} else if tc.name == "Same Platform" {
// For same platform, we expect sysroot only on macOS
if runtime.GOOS == "darwin" && !hasSysroot {
t.Error("Missing --sysroot flag in CCFLAGS on macOS")
}
// On Linux and other platforms, sysroot is not necessarily required
}
} }
if tc.expectCFlags { if tc.expectCFlags {
@@ -147,9 +156,11 @@ func TestUseCrossCompileSDK(t *testing.T) {
} }
} }
} else { } else {
if /*len(export.CCFLAGS) != 0 ||*/ len(export.CFLAGS) != 0 { // For unsupported targets, we still expect some basic flags to be set
t.Errorf("Expected empty export, got CCFLAGS=%v, CFLAGS=%v, LDFLAGS=%v", // since the implementation now always sets up ESP Clang environment
export.CCFLAGS, export.CFLAGS, export.LDFLAGS) // Only check that we don't have specific SDK-related flags for unsupported targets
if tc.name == "Unsupported Target" && len(export.CFLAGS) != 0 {
t.Errorf("Expected empty CFLAGS for unsupported target, got CFLAGS=%v", export.CFLAGS)
} }
} }
}) })