From 8ce6c3b9abc09568567a24e35ab04b8e526efa31 Mon Sep 17 00:00:00 2001 From: Haolan Date: Tue, 9 Sep 2025 17:48:54 +0800 Subject: [PATCH] chore: fix commets and format Update internal/crosscompile/compile/rtlib/rt_test.go Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Update internal/crosscompile/compile/libc/libc_test.go Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Update internal/crosscompile/compile/libc/libc_test.go Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> chore: format contents --- internal/crosscompile/compile/libc/libc_test.go | 4 ++-- internal/crosscompile/compile/rtlib/rt_test.go | 2 +- internal/crosscompile/libc.go | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/internal/crosscompile/compile/libc/libc_test.go b/internal/crosscompile/compile/libc/libc_test.go index 7b79675b..9a994ef3 100644 --- a/internal/crosscompile/compile/libc/libc_test.go +++ b/internal/crosscompile/compile/libc/libc_test.go @@ -325,7 +325,7 @@ func TestGetNewlibESP32ConfigRISCV(t *testing.T) { } else { for i, expected := range expectedCFlags { if config.ExportCFlags[i] != expected { - t.Errorf("LibcCFlags[%d] mismatch. Expected '%s', got '%s'", i, expected, config.ExportCFlags[i]) + t.Errorf("ExportCFlags[%d] mismatch. Expected '%s', got '%s'", i, expected, config.ExportCFlags[i]) } } } @@ -458,7 +458,7 @@ func TestGetNewlibESP32ConfigXtensa(t *testing.T) { } else { for i, expected := range expectedCFlags { if config.ExportCFlags[i] != expected { - t.Errorf("LibcCFlags[%d] mismatch. Expected '%s', got '%s'", i, expected, config.ExportCFlags[i]) + t.Errorf("ExportCFlags[%d] mismatch. Expected '%s', got '%s'", i, expected, config.ExportCFlags[i]) } } } diff --git a/internal/crosscompile/compile/rtlib/rt_test.go b/internal/crosscompile/compile/rtlib/rt_test.go index 427ecd5b..6e7d1541 100644 --- a/internal/crosscompile/compile/rtlib/rt_test.go +++ b/internal/crosscompile/compile/rtlib/rt_test.go @@ -5,7 +5,7 @@ import ( "testing" ) -func TestGetNewlibESP32Config_LibConfig(t *testing.T) { +func TestGetCompilerRTConfig_LibConfig(t *testing.T) { config := GetCompilerRTConfig() // Test basic configuration fields diff --git a/internal/crosscompile/libc.go b/internal/crosscompile/libc.go index b7feefc3..c19eeab9 100644 --- a/internal/crosscompile/libc.go +++ b/internal/crosscompile/libc.go @@ -13,7 +13,7 @@ import ( var needSkipDownload = false // getLibcCompileConfigByName retrieves libc compilation configuration by name -// Returns compilation file lists and corresponding cflags +// Returns the actual libc output dir, compilation config and err func getLibcCompileConfigByName(baseDir, libcName, target, mcpu string) (outputDir string, cfg compile.CompileConfig, err error) { if libcName == "" { err = fmt.Errorf("libc name cannot be empty") @@ -48,7 +48,7 @@ func getLibcCompileConfigByName(baseDir, libcName, target, mcpu string) (outputD } // getRTCompileConfigByName retrieves runtime library compilation configuration by name -// Returns compilation file lists and corresponding flags for the specified runtime library +// Returns the actual libc output dir, compilation config and err func getRTCompileConfigByName(baseDir, rtName, target string) (outputDir string, cfg compile.CompileConfig, err error) { if rtName == "" { err = fmt.Errorf("rt name cannot be empty")