admin/llgo
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: address code review feedback for size report feature

Browse Source 
- Fix error handling priority: check waitErr first, then parseErr, then closeErr
- Optimize O(n²) symbol lookup by checking next symbol first
- Add ELF section constants (SHN_LORESERVE, SHN_ABS, etc.) and use them
- Fix documentation: add missing --elf-output-style=LLVM flag
- Fix documentation: correct field names from pkg.ID to pkg.PkgPath

Generated with [codeagent](https://github.com/qbox/codeagent)
Co-authored-by: cpunion <8459+cpunion@users.noreply.github.com>
This commit is contained in:
xgopilot
2025-11-17 08:15:12 +00:00
parent dc39b84187
commit ae690476ba
2 changed files with 31 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
doc/size-report.md
View File

@@ -6,7 +6,7 @@ document captures the parsing strategy and new aggregation controls.
## Parsing Strategy
- We invoke `llvm-readelf --all <binary>` and parse the textual output with an
- We invoke `llvm-readelf --elf-output-style=LLVM --all <binary>` and parse the textual output with an
indentation-sensitive state machine (no JSON). Only the `Sections` and
`Symbols` blocks are inspected.
- Section metadata records the index, address, size, name, and segment. Each
@@ -24,11 +24,11 @@ document captures the parsing strategy and new aggregation controls.
| Level | Behavior |
|-----------|---------------------------------------------------------------------------|
| `full` | Keeps the raw owner from the symbol name (previous behavior). |
| `package` | Uses the list of packages built in `build.Do` and groups by `pkg.ID`. |
| `module`* | Default. Groups by `pkg.Module.Path` (or `pkg.ID` if the module is nil). |
| `package` | Uses the list of packages built in `build.Do` and groups by `pkg.PkgPath`. |
| `module`* | Default. Groups by `pkg.Module.Path` (or `pkg.PkgPath` if the module is nil). |
Matching is performed by checking whether the demangled symbol name begins with
`pkg.ID + "."`. Symbols that do not match any package and contain `llgo` are
`pkg.PkgPath + "."`. Symbols that do not match any package and contain `llgo` are
bucketed into `llgo-stubs`; other unmatched entries keep their original owner
names so we can inspect them later.