Adding local pip-review (#433)

This commit is contained in:
MonstrousOgre
2023-05-20 23:03:59 +05:30
committed by GitHub
parent f06b7c0807
commit 54301a6a17
4 changed files with 35 additions and 2 deletions

View File

@@ -106,8 +106,9 @@
#nix_arguments = "--flake" #nix_arguments = "--flake"
[python] [python]
#enable_pip_review = true ###disabled by default #enable_pip_review = true ###disabled by default
#enable_pipupgrade = true ###disabled by default #enable_pip_review_local = true ###disabled by default
#enable_pipupgrade = true ###disabled by default
[windows] [windows]
# Manually select Windows updates # Manually select Windows updates

View File

@@ -130,6 +130,7 @@ pub enum Step {
Pearl, Pearl,
Pip3, Pip3,
PipReview, PipReview,
PipReviewLocal,
Pipupgrade, Pipupgrade,
Pipx, Pipx,
Pkg, Pkg,
@@ -200,6 +201,7 @@ pub struct Windows {
#[serde(deny_unknown_fields)] #[serde(deny_unknown_fields)]
pub struct Python { pub struct Python {
enable_pip_review: Option<bool>, enable_pip_review: Option<bool>,
enable_pip_review_local: Option<bool>,
enable_pipupgrade: Option<bool>, enable_pipupgrade: Option<bool>,
} }
@@ -1138,6 +1140,14 @@ impl Config {
.and_then(|python| python.enable_pip_review) .and_then(|python| python.enable_pip_review)
.unwrap_or(false); .unwrap_or(false);
} }
pub fn enable_pip_review_local(&self) -> bool {
return self
.config_file
.python
.as_ref()
.and_then(|python| python.enable_pip_review_local)
.unwrap_or(false);
}
pub fn display_time(&self) -> bool { pub fn display_time(&self) -> bool {
self.config_file.display_time.unwrap_or(true) self.config_file.display_time.unwrap_or(true)

View File

@@ -384,6 +384,9 @@ For more information about this issue see https://askubuntu.com/questions/110969
runner.execute(Step::Mamba, "mamba", || generic::run_mamba_update(&ctx))?; runner.execute(Step::Mamba, "mamba", || generic::run_mamba_update(&ctx))?;
runner.execute(Step::Pip3, "pip3", || generic::run_pip3_update(run_type))?; runner.execute(Step::Pip3, "pip3", || generic::run_pip3_update(run_type))?;
runner.execute(Step::PipReview, "pip-review", || generic::run_pip_review_update(&ctx))?; runner.execute(Step::PipReview, "pip-review", || generic::run_pip_review_update(&ctx))?;
runner.execute(Step::PipReviewLocal, "pip-review (local)", || {
generic::run_pip_review_local_update(&ctx)
})?;
runner.execute(Step::Pipupgrade, "pipupgrade", || generic::run_pipupgrade_update(&ctx))?; runner.execute(Step::Pipupgrade, "pipupgrade", || generic::run_pipupgrade_update(&ctx))?;
runner.execute(Step::Ghcup, "ghcup", || generic::run_ghcup_update(run_type))?; runner.execute(Step::Ghcup, "ghcup", || generic::run_ghcup_update(run_type))?;
runner.execute(Step::Stack, "stack", || generic::run_stack_update(run_type))?; runner.execute(Step::Stack, "stack", || generic::run_stack_update(run_type))?;

View File

@@ -414,6 +414,25 @@ pub fn run_pip_review_update(ctx: &ExecutionContext) -> Result<()> {
Ok(()) Ok(())
} }
pub fn run_pip_review_local_update(ctx: &ExecutionContext) -> Result<()> {
let pip_review = require("pip-review")?;
print_separator("pip-review (local)");
if !ctx.config().enable_pip_review_local() {
print_warning(
"Pip-review (local) is disabled by default. Enable it by setting enable_pip_review_local=true in the configuration.",
);
return Err(SkipStep(String::from("Pip-review (local) is disabled by default")).into());
}
ctx.run_type()
.execute(pip_review)
.arg("--local")
.arg("--auto")
.status_checked_with_codes(&[1])?;
Ok(())
}
pub fn run_pipupgrade_update(ctx: &ExecutionContext) -> Result<()> { pub fn run_pipupgrade_update(ctx: &ExecutionContext) -> Result<()> {
let pipupgrade = require("pipupgrade")?; let pipupgrade = require("pipupgrade")?;