Really fix macOS

src/macos.rs

@@ -4,14 +4,17 @@ use failure;
 use std::process::Command;
 
 #[must_use]
-pub fn upgrade_macos(terminal: &mut Terminal) -> Result<(), failure::Error> {
+pub fn upgrade_macos(terminal: &mut Terminal) -> Option<(&'static str, bool)> {
     terminal.print_separator("App Store");
 
-    Command::new("softwareupdate")
+    let success = || -> Result<(), failure::Error> {
-        .args(&["--install", "--all"])
+        Command::new("softwareupdate")
-        .spawn()?
+            .args(&["--install", "--all"])
-        .wait()?
+            .spawn()?
-        .check()?;
+            .wait()?
+            .check()?;
+        Ok(())
+    }().is_ok();
 
-    Ok(())
+    Some(("App Store", success))
 }