Files
cc-switch/tests/hooks/useMcpActions.test.tsx
Jason 9e8abf5f26 feat(frontend): implement unified MCP panel for v3.7.0
Complete Phase 3 (P0) frontend implementation for unified MCP management:

**New Files:**
- src/hooks/useMcp.ts: React Query hooks for unified MCP operations
- src/components/mcp/UnifiedMcpPanel.tsx: Unified MCP management panel
- src/components/ui/checkbox.tsx: Checkbox component from shadcn/ui

**Features:**
- Unified panel with three-column layout: server info + app checkboxes + actions
- Multi-app control: Claude/Codex/Gemini checkboxes for each server
- Real-time stats: Show enabled server counts per app
- Full CRUD operations: Add, edit, delete, sync all servers

**Integration:**
- Replace old app-specific McpPanel with UnifiedMcpPanel in App.tsx
- Update McpFormModal to support unified mode with apps field
- Add i18n support: mcp.unifiedPanel namespace (zh/en)

**Type Safety:**
- Ensure McpServer.apps field always initialized
- Fix all test files to include apps field
- TypeScript type check passes 

**Architecture:**
- Single source of truth: mcp.servers manages all MCP configs
- Per-server app control: apps.claude/codex/gemini boolean flags
- Backward compatible: McpFormModal supports both unified and legacy modes

Next: P1 tasks (import dialogs, sub-components, tests)
2025-11-14 15:24:48 +08:00

282 lines
9.5 KiB
TypeScript

import { renderHook, act, waitFor } from "@testing-library/react";
import { describe, it, expect, beforeEach, vi } from "vitest";
import { useMcpActions } from "@/hooks/useMcpActions";
import type { McpServer } from "@/types";
const toastSuccessMock = vi.fn();
const toastErrorMock = vi.fn();
vi.mock("sonner", () => ({
toast: {
success: (...args: unknown[]) => toastSuccessMock(...args),
error: (...args: unknown[]) => toastErrorMock(...args),
},
}));
const getConfigMock = vi.fn();
const setEnabledMock = vi.fn();
const upsertServerInConfigMock = vi.fn();
const deleteServerInConfigMock = vi.fn();
const syncEnabledToClaudeMock = vi.fn();
const syncEnabledToCodexMock = vi.fn();
vi.mock("@/lib/api", () => ({
mcpApi: {
getConfig: (...args: unknown[]) => getConfigMock(...args),
setEnabled: (...args: unknown[]) => setEnabledMock(...args),
upsertServerInConfig: (...args: unknown[]) => upsertServerInConfigMock(...args),
deleteServerInConfig: (...args: unknown[]) => deleteServerInConfigMock(...args),
syncEnabledToClaude: (...args: unknown[]) => syncEnabledToClaudeMock(...args),
syncEnabledToCodex: (...args: unknown[]) => syncEnabledToCodexMock(...args),
},
}));
const createServer = (overrides: Partial<McpServer> = {}): McpServer => ({
id: "server-1",
name: "Test Server",
description: "desc",
enabled: false,
apps: { claude: false, codex: false, gemini: false },
server: {
type: "stdio",
command: "run.sh",
args: [],
env: {},
},
...overrides,
});
const mockConfigResponse = (servers: Record<string, McpServer>) => ({
configPath: "/mock/config.json",
servers,
});
const createDeferred = <T,>() => {
let resolve!: (value: T | PromiseLike<T>) => void;
const promise = new Promise<T>((res) => {
resolve = res;
});
return { promise, resolve };
};
describe("useMcpActions", () => {
beforeEach(() => {
getConfigMock.mockReset();
setEnabledMock.mockReset();
upsertServerInConfigMock.mockReset();
deleteServerInConfigMock.mockReset();
syncEnabledToClaudeMock.mockReset();
syncEnabledToCodexMock.mockReset();
toastSuccessMock.mockReset();
toastErrorMock.mockReset();
getConfigMock.mockResolvedValue(mockConfigResponse({}));
setEnabledMock.mockResolvedValue(true);
upsertServerInConfigMock.mockResolvedValue(true);
deleteServerInConfigMock.mockResolvedValue(true);
});
const renderUseMcpActions = () => renderHook(() => useMcpActions("claude"));
it("reloads servers and toggles loading state", async () => {
const server = createServer();
const deferred = createDeferred<ReturnType<typeof mockConfigResponse>>();
getConfigMock.mockReturnValueOnce(deferred.promise);
const { result } = renderUseMcpActions();
let reloadPromise: Promise<void> | undefined;
await act(async () => {
reloadPromise = result.current.reload();
});
await waitFor(() => expect(result.current.loading).toBe(true));
deferred.resolve(mockConfigResponse({ [server.id]: server }));
await act(async () => {
await reloadPromise;
});
expect(getConfigMock).toHaveBeenCalledWith("claude");
expect(result.current.loading).toBe(false);
expect(result.current.servers).toEqual({ [server.id]: server });
});
it("shows toast error when reload fails", async () => {
const error = new Error("load failed");
getConfigMock.mockRejectedValueOnce(error);
const { result } = renderUseMcpActions();
await act(async () => {
await result.current.reload();
});
expect(toastErrorMock).toHaveBeenCalledWith("load failed", { duration: 6000 });
expect(result.current.servers).toEqual({});
expect(result.current.loading).toBe(false);
});
it("toggles enabled flag optimistically and emits success toasts", async () => {
const server = createServer({ enabled: false });
getConfigMock.mockResolvedValueOnce(mockConfigResponse({ [server.id]: server }));
const { result } = renderUseMcpActions();
await act(async () => {
await result.current.reload();
});
await act(async () => {
await result.current.toggleEnabled(server.id, true);
});
expect(setEnabledMock).toHaveBeenCalledWith("claude", server.id, true);
expect(result.current.servers[server.id].enabled).toBe(true);
expect(toastSuccessMock).toHaveBeenLastCalledWith("mcp.msg.enabled", { duration: 1500 });
await act(async () => {
await result.current.toggleEnabled(server.id, false);
});
expect(setEnabledMock).toHaveBeenLastCalledWith("claude", server.id, false);
expect(result.current.servers[server.id].enabled).toBe(false);
expect(toastSuccessMock).toHaveBeenLastCalledWith("mcp.msg.disabled", { duration: 1500 });
});
it("rolls back state and shows error toast when toggle fails", async () => {
const server = createServer({ enabled: false });
getConfigMock.mockResolvedValueOnce(mockConfigResponse({ [server.id]: server }));
const { result } = renderUseMcpActions();
await act(async () => {
await result.current.reload();
});
setEnabledMock.mockRejectedValueOnce(new Error("toggle failed"));
await act(async () => {
await result.current.toggleEnabled(server.id, true);
});
expect(result.current.servers[server.id].enabled).toBe(false);
expect(toastErrorMock).toHaveBeenCalledWith("toggle failed", { duration: 6000 });
});
it("saves server configuration and refreshes list", async () => {
const serverInput = createServer({ id: "old-id", enabled: true });
const savedServer = { ...serverInput, id: "new-server" };
getConfigMock.mockResolvedValueOnce(mockConfigResponse({ [savedServer.id]: savedServer }));
const { result } = renderUseMcpActions();
await act(async () => {
await result.current.saveServer("new-server", serverInput, { syncOtherSide: true });
});
expect(upsertServerInConfigMock).toHaveBeenCalledWith(
"claude",
"new-server",
{ ...serverInput, id: "new-server" },
{ syncOtherSide: true },
);
expect(result.current.servers["new-server"]).toEqual(savedServer);
expect(toastSuccessMock).toHaveBeenCalledWith("mcp.msg.saved", { duration: 1500 });
});
it("propagates error when saveServer fails", async () => {
const serverInput = createServer({ id: "input-id" });
const failure = new Error("cannot save");
upsertServerInConfigMock.mockRejectedValueOnce(failure);
const { result } = renderUseMcpActions();
let captured: unknown;
await act(async () => {
try {
await result.current.saveServer("server-1", serverInput);
} catch (err) {
captured = err;
}
});
expect(upsertServerInConfigMock).toHaveBeenCalled();
expect(getConfigMock).not.toHaveBeenCalled();
expect(captured).toBe(failure);
expect(toastErrorMock).toHaveBeenCalledWith("cannot save", { duration: 6000 });
expect(toastSuccessMock).not.toHaveBeenCalled();
});
it("deletes server and refreshes list", async () => {
const server = createServer();
getConfigMock.mockResolvedValueOnce(mockConfigResponse({ [server.id]: server }));
const { result } = renderUseMcpActions();
await act(async () => {
await result.current.reload();
});
getConfigMock.mockResolvedValueOnce(mockConfigResponse({}));
await act(async () => {
await result.current.deleteServer(server.id);
});
expect(deleteServerInConfigMock).toHaveBeenCalledWith("claude", server.id);
expect(result.current.servers[server.id]).toBeUndefined();
expect(toastSuccessMock).toHaveBeenCalledWith("mcp.msg.deleted", { duration: 1500 });
});
it("propagates delete error and keeps state", async () => {
const server = createServer();
getConfigMock.mockResolvedValueOnce(mockConfigResponse({ [server.id]: server }));
const { result } = renderUseMcpActions();
await act(async () => {
await result.current.reload();
});
const failure = new Error("delete failed");
deleteServerInConfigMock.mockRejectedValueOnce(failure);
let captured: unknown;
await act(async () => {
try {
await result.current.deleteServer(server.id);
} catch (err) {
captured = err;
}
});
expect(deleteServerInConfigMock).toHaveBeenCalledWith("claude", server.id);
expect(result.current.servers[server.id]).toEqual(server);
expect(captured).toBe(failure);
expect(toastErrorMock).toHaveBeenCalledWith("delete failed", { duration: 6000 });
});
it("maps backend error message when save fails with known detail", async () => {
const serverInput = createServer({ id: "input-id" });
const backendError = { message: "stdio 类型的 MCP 服务器必须包含 command 字段" };
upsertServerInConfigMock.mockRejectedValueOnce(backendError);
const { result } = renderUseMcpActions();
await expect(async () =>
result.current.saveServer("server-1", serverInput),
).rejects.toEqual(backendError);
expect(toastErrorMock).toHaveBeenCalledWith("mcp.error.commandRequired", {
duration: 6000,
});
});
it("syncs enabled state to counterpart when appType is claude", async () => {
const server = createServer();
getConfigMock.mockResolvedValueOnce(mockConfigResponse({ [server.id]: server }));
const { result } = renderUseMcpActions();
await act(async () => {
await result.current.reload();
});
await act(async () => {
await result.current.toggleEnabled(server.id, true);
});
expect(setEnabledMock).toHaveBeenCalledWith("claude", server.id, true);
expect(syncEnabledToClaudeMock).not.toHaveBeenCalled();
});
});