admin/gluetun
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

chore(server): replace 404 with 401 for unsupported routes and methods

Browse Source
This commit is contained in:
Quentin McGaw
2022-08-21 21:23:02 +00:00
parent f8bf32bb34
commit 54dcf28b31
6 changed files with 13 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
internal/server/dns.go
View File

@@ -32,10 +32,10 @@ func (h *dnsHandler) ServeHTTP(w http.ResponseWriter, r *http.Request) {
case http.MethodPut:
h.setStatus(w, r)
default:
http.Error(w, "", http.StatusNotFound)
http.Error(w, "method "+r.Method+" not supported", http.StatusBadRequest)
}
default:
http.Error(w, "", http.StatusNotFound)
http.Error(w, "route "+r.RequestURI+" not supported", http.StatusBadRequest)
}
}

4
internal/server/handlerv0.go
View File

@@ -28,7 +28,7 @@ type handlerV0 struct {
func (h *handlerV0) ServeHTTP(w http.ResponseWriter, r *http.Request) {
if r.Method != http.MethodGet {
http.Error(w, "unversioned API: only supports GET method", http.StatusNotFound)
http.Error(w, "unversioned API: only supports GET method", http.StatusBadRequest)
return
}
switch r.RequestURI {
@@ -63,6 +63,6 @@ func (h *handlerV0) ServeHTTP(w http.ResponseWriter, r *http.Request) {
h.logger.Warn(err.Error())
}
default:
http.Error(w, "unversioned API: requested URI not found", http.StatusNotFound)
http.Error(w, "unversioned API: requested URI not found", http.StatusBadRequest)
}
}

2
internal/server/handlerv1.go
View File

@@ -44,7 +44,7 @@ func (h *handlerV1) ServeHTTP(w http.ResponseWriter, r *http.Request) {
h.publicip.ServeHTTP(w, r)
default:
errString := fmt.Sprintf("%s %s not found", r.Method, r.RequestURI)
http.Error(w, errString, http.StatusNotFound)
http.Error(w, errString, http.StatusBadRequest)
}
}

8
internal/server/openvpn.go
View File

@@ -34,24 +34,24 @@ func (h *openvpnHandler) ServeHTTP(w http.ResponseWriter, r *http.Request) {
case http.MethodPut:
h.setStatus(w, r)
default:
http.Error(w, "", http.StatusNotFound)
http.Error(w, "method "+r.Method+" not supported", http.StatusBadRequest)
}
case "/settings":
switch r.Method {
case http.MethodGet:
h.getSettings(w)
default:
http.Error(w, "", http.StatusNotFound)
http.Error(w, "method "+r.Method+" not supported", http.StatusBadRequest)
}
case "/portforwarded":
switch r.Method {
case http.MethodGet:
h.getPortForwarded(w)
default:
http.Error(w, "", http.StatusNotFound)
http.Error(w, "method "+r.Method+" not supported", http.StatusBadRequest)
}
default:
http.Error(w, "", http.StatusNotFound)
http.Error(w, "route "+r.RequestURI+" not supported", http.StatusBadRequest)
}
}

4
internal/server/publicip.go
View File

@@ -26,10 +26,10 @@ func (h *publicIPHandler) ServeHTTP(w http.ResponseWriter, r *http.Request) {
case http.MethodGet:
h.getPublicIP(w)
default:
http.Error(w, "", http.StatusNotFound)
http.Error(w, "method "+r.Method+" not supported", http.StatusBadRequest)
}
default:
http.Error(w, "", http.StatusNotFound)
http.Error(w, "route "+r.RequestURI+" not supported", http.StatusBadRequest)
}
}

4
internal/server/updater.go
View File

@@ -44,10 +44,10 @@ func (h *updaterHandler) ServeHTTP(w http.ResponseWriter, r *http.Request) {
case http.MethodPut:
h.setStatus(w, r)
default:
http.Error(w, "", http.StatusNotFound)
http.Error(w, "method "+r.Method+" not supported", http.StatusBadRequest)
}
default:
http.Error(w, "", http.StatusNotFound)
http.Error(w, "route "+r.RequestURI+" not supported", http.StatusBadRequest)
}
}