admin/grpc
1
0
Fork 0
mirror of https://github.com/grpc/grpc.git synced 2026-01-24 10:53:30 +08:00
Code Issues Packages Projects Releases Wiki Activity

[CI] Re-enabled modernize-unary-static-assert (#38333)

Browse Source 
Re-enabled `modernize-unary-static-assert` which was disabled temporarily by https://github.com/grpc/grpc/pull/37919

Closes #38333

PiperOrigin-RevId: 713080136
This commit is contained in:
Esun Kim
2025-01-07 16:31:15 -08:00
committed by Copybara-Service
parent d4fa2e6d25
commit 048ea42420
3 changed files with 10 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
.clang-tidy
View File

@@ -129,6 +129,7 @@ Checks: '-*,
modernize-replace-auto-ptr,
modernize-replace-random-shuffle,
modernize-shrink-to-fit,
modernize-unary-static-assert,
modernize-use-bool-literals,
modernize-use-noexcept,
modernize-use-nullptr,

15
src/core/util/matchers.h
View File

@@ -91,20 +91,15 @@ class HeaderMatcher {
// the corresponding StringMatcher::Type enum values, so that it's safe to
// convert by casting when delegating to StringMatcher.
static_assert(static_cast<StringMatcher::Type>(Type::kExact) ==
StringMatcher::Type::kExact,
"");
StringMatcher::Type::kExact);
static_assert(static_cast<StringMatcher::Type>(Type::kPrefix) ==
StringMatcher::Type::kPrefix,
"");
StringMatcher::Type::kPrefix);
static_assert(static_cast<StringMatcher::Type>(Type::kSuffix) ==
StringMatcher::Type::kSuffix,
"");
StringMatcher::Type::kSuffix);
static_assert(static_cast<StringMatcher::Type>(Type::kSafeRegex) ==
StringMatcher::Type::kSafeRegex,
"");
StringMatcher::Type::kSafeRegex);
static_assert(static_cast<StringMatcher::Type>(Type::kContains) ==
StringMatcher::Type::kContains,
"");
StringMatcher::Type::kContains);
// Creates HeaderMatcher instance. Returns error status on failure.
static absl::StatusOr<HeaderMatcher> Create(absl::string_view name, Type type,

12
src/core/xds/xds_client/xds_client.h
View File

@@ -278,18 +278,14 @@ class XdsClient : public DualRefCounted<XdsClient> {
NACKED,
};
static_assert(static_cast<ClientResourceStatus>(envoy_admin_v3_REQUESTED) ==
ClientResourceStatus::REQUESTED,
"");
ClientResourceStatus::REQUESTED);
static_assert(
static_cast<ClientResourceStatus>(envoy_admin_v3_DOES_NOT_EXIST) ==
ClientResourceStatus::DOES_NOT_EXIST,
"");
ClientResourceStatus::DOES_NOT_EXIST);
static_assert(static_cast<ClientResourceStatus>(envoy_admin_v3_ACKED) ==
ClientResourceStatus::ACKED,
"");
ClientResourceStatus::ACKED);
static_assert(static_cast<ClientResourceStatus>(envoy_admin_v3_NACKED) ==
ClientResourceStatus::NACKED,
"");
ClientResourceStatus::NACKED);
void AddWatcher(RefCountedPtr<ResourceWatcherInterface> watcher) {
watchers_.insert(std::move(watcher));